Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: ui/file_manager/audio_player/elements/audio_player.js

Issue 1495873002: AudioPlayer: Stop using Object.observe() and Array.observe(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Listen to property-change events for four states explicitly. Stop using Array.observe. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/file_manager/audio_player/elements/track_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/audio_player/elements/audio_player.js
diff --git a/ui/file_manager/audio_player/elements/audio_player.js b/ui/file_manager/audio_player/elements/audio_player.js
index df977197802e974e766f38e9a70b1fa6d24ab454..917168dccd34da7e5f58a55a6517440e3c641bfb 100644
--- a/ui/file_manager/audio_player/elements/audio_player.js
+++ b/ui/file_manager/audio_player/elements/audio_player.js
@@ -29,7 +29,7 @@ Polymer({
*/
shuffle: {
type: Boolean,
- observer: 'shuffleChanged'
+ notify: true
},
/**
@@ -37,7 +37,7 @@ Polymer({
*/
repeat: {
type: Boolean,
- observer: 'repeatChanged'
+ notify: true
},
/**
@@ -45,7 +45,7 @@ Polymer({
*/
volume: {
type: Number,
- observer: 'volumeChanged'
+ notify: true
},
/**
@@ -53,7 +53,7 @@ Polymer({
*/
expanded: {
type: Boolean,
- observer: 'expandedChanged'
+ notify: true
},
/**
@@ -65,16 +65,6 @@ Polymer({
},
/**
- * Model object of the Audio Player.
- * @type {AudioPlayerModel}
- */
- model: {
- type: Object,
- value: null,
- observer: 'modelChanged'
- },
-
- /**
* URL of the current track. (exposed publicly for tests)
*/
currenttrackurl: {
@@ -104,41 +94,6 @@ Polymer({
wasPlayingOnDragStart_: false,
/**
- * Handles change event for shuffle mode.
- * @param {boolean} shuffle
- */
- shuffleChanged: function(shuffle) {
- if (this.model)
- this.model.shuffle = shuffle;
- },
-
- /**
- * Handles change event for repeat mode.
- * @param {boolean} repeat
- */
- repeatChanged: function(repeat) {
- if (this.model)
- this.model.repeat = repeat;
- },
-
- /**
- * Handles change event for audio volume.
- * @param {number} volume
- */
- volumeChanged: function(volume) {
- if (this.model)
- this.model.volume = volume;
- },
-
- /**
- * Handles change event for expanded state of track list.
- */
- expandedChanged: function(expanded) {
- if (this.model)
- this.model.expanded = expanded;
- },
-
- /**
* Initializes an element. This method is called automatically when the
* element is ready.
*/
@@ -215,21 +170,6 @@ Polymer({
},
/**
- * Invoked when the model changed.
- * @param {AudioPlayerModel} newModel New model.
- * @param {AudioPlayerModel} oldModel Old model.
- */
- modelChanged: function(newModel, oldModel) {
- // Setting up the UI
- if (newModel !== oldModel && newModel) {
- this.shuffle = newModel.shuffle;
- this.repeat = newModel.repeat;
- this.volume = newModel.volume;
- this.expanded = newModel.expanded;
- }
- },
-
- /**
* Invoked when time is changed.
* @param {number} newValue new time (in ms).
* @param {number} oldValue old time (in ms).
« no previous file with comments | « no previous file | ui/file_manager/audio_player/elements/track_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698