Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Side by Side Diff: ui/file_manager/externs/es7_workaround.js

Issue 1495873002: AudioPlayer: Stop using Object.observe() and Array.observe(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Partial definitions for ECMAScript 7. To compile Files.app, some 6 * @fileoverview Partial definitions for ECMAScript 7. To compile Files.app, some
7 * definitions are defined in this file. They should be removed once ES7 7 * definitions are defined in this file. They should be removed once ES7
8 * definitions are ready in closure compiler by default. 8 * definitions are ready in closure compiler by default.
9 * @externs 9 * @externs
10 */ 10 */
11 11
12 /** 12 /**
13 * @param {!Object} obj
14 * @param {function(!Array<!Object>)} callback
15 * @param {!Array<string>=} acceptList
16 */
17 Object.observe = function(obj, callback, acceptList) {};
18
19 /**
20 * @param {!Object} obj
21 * @param {function(!Array<!Object>)} callback
22 */
23 Object.unobserve = function(obj, callback) {};
24
25 /**
26 * @param {!Array} arr 13 * @param {!Array} arr
27 * @param {function(!Array<!Object>)} callback 14 * @param {function(!Array<!Object>)} callback
28 */ 15 */
29 Array.observe = function(arr, callback) {}; 16 Array.observe = function(arr, callback) {};
yoshiki 2015/12/07 05:39:21 Could you remove them as well?
fukino 2015/12/07 07:21:01 Done. I think we can simple stop listening to the
30 17
31 /** 18 /**
32 * @param {!Array} arr 19 * @param {!Array} arr
33 * @param {function(!Array<!Object>)} callback 20 * @param {function(!Array<!Object>)} callback
34 */ 21 */
35 Array.unobserve = function(arr, callback) {}; 22 Array.unobserve = function(arr, callback) {};
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698