Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 1495803003: X87: [crankshaft] Deoptimize if HHasInPrototypeChainAndBranch hits a proxy. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [crankshaft] Deoptimize if HHasInPrototypeChainAndBranch hits a proxy. port a330af0ed1f237ba17ac2242ce16cad5616c0597 (r32539) original commit message: The optimized code generated by Crankshaft cannot properly deal with proxies (in the prototype chain), and there's probably no point in trying to make that work^Wfast with Crankshaft at all. TurboFan will handle that properly; Crankshaft just bails out to fullcodegen, which then goes to the runtime, which should do the right thing soon. BUG= Committed: https://crrev.com/69ea09dd15008874f012a8a5d4b571dc0feac0b6 Cr-Commit-Position: refs/heads/master@{#32594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-03 08:35:19 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-04 03:29:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495803003/1
5 years ago (2015-12-04 03:29:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 04:55:40 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-04 04:55:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69ea09dd15008874f012a8a5d4b571dc0feac0b6
Cr-Commit-Position: refs/heads/master@{#32594}

Powered by Google App Engine
This is Rietveld 408576698