Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 14958004: Move global-constructors-listing.html test to webexposed/ (Closed)

Created:
7 years, 7 months ago by do-not-use
Modified:
7 years, 7 months ago
CC:
blink-reviews, lgombos, Dirk Pranke, Julie Parent
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move global-constructors-listing.html test to webexposed/ Move fast/dom/global-constructors-listing.html test case to webexposed/ folder so it will also be tested against the stable configuration once we switch to Content Shell. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149942

Patch Set 1 #

Patch Set 2 : Trying to reupload with --no-find-copies #

Patch Set 3 : Fix paths to JS files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -474 lines) Patch
D LayoutTests/fast/dom/global-constructors-listing.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/dom/global-constructors-listing-expected.txt View 1 chunk +0 lines, -446 lines 0 comments Download
A + LayoutTests/webexposed/global-constructors-listing.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/webexposed/global-constructors-listing-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
do-not-use
7 years, 7 months ago (2013-05-07 08:05:30 UTC) #1
eseidel
lgtm Thanks.
7 years, 7 months ago (2013-05-07 08:25:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14958004/1
7 years, 7 months ago (2013-05-07 08:25:47 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7020
7 years, 7 months ago (2013-05-07 08:59:46 UTC) #4
do-not-use
On 2013/05/07 08:59:46, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 7 months ago (2013-05-07 09:56:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14958004/12001
7 years, 7 months ago (2013-05-07 09:57:56 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7028
7 years, 7 months ago (2013-05-07 10:32:25 UTC) #7
do-not-use
On 2013/05/07 09:56:24, Christophe Dumez wrote: > On 2013/05/07 08:59:46, I haz the power (commit-bot) ...
7 years, 7 months ago (2013-05-07 14:23:07 UTC) #8
eseidel
I'm not sure what the current status of layout test results and rieteld is. I ...
7 years, 7 months ago (2013-05-08 01:48:01 UTC) #9
ojan
On 2013/05/08 01:48:01, Eric Seidel (Google) wrote: > I'm not sure what the current status ...
7 years, 7 months ago (2013-05-08 01:55:48 UTC) #10
do-not-use
On 2013/05/08 01:55:48, ojan wrote: > On 2013/05/08 01:48:01, Eric Seidel (Google) wrote: > > ...
7 years, 7 months ago (2013-05-08 06:14:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14958004/24001
7 years, 7 months ago (2013-05-08 06:24:00 UTC) #12
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 07:12:35 UTC) #13
Message was sent while issue was closed.
Change committed as 149942

Powered by Google App Engine
This is Rietveld 408576698