[Resumption 8/11] Remove intermediate files when no longer necessary.

content/browser/download/download_manager_impl.cc

Index: content/browser/download/download_manager_impl.cc
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc
index 5dc5aa17b59f3220bc75a47090b8335bd226c7f9..08b163d32be5e9d454e59d1227a04c4afda6faca 100644
--- a/content/browser/download/download_manager_impl.cc
+++ b/content/browser/download/download_manager_impl.cc
@@ -389,9 +389,11 @@ DownloadItem* DownloadManagerImpl::StartDownload(
   } else {
     DownloadMap::iterator item_iterator = downloads_.find(id.local());
     // Trying to resume an interrupted download.
-    if (item_iterator == downloads_.end()) {
+    if (item_iterator == downloads_.end() ||
+        item_iterator->second->IsCancelled()) {

[Randy Smith (Not in Mondays), 2013/05/21 21:40:37]

(This is mostly just rambling--the final conclusion is that I'm ok with this
code given context.)

I wince at this check; it "feels" like it should be in the DownloadItem.  I
can't come up offhand with a better way to do it, though; when I try, my mind
goes to "well, why shouldn't you be able to resume (== restart) a cancelled
download?" and that's for the future :-}.  And when I think about it some more,
I also feel like the rest of this function should be inside of DownloadItemImpl,
and my memory is that I tried to do that when I was writing it and it didn't
work very well (probably around the DownloadFileFactory being a member of
DownloadManagerImpl.)  So there's probably not a good way to clean this up, and
it'll disappear when we get to restarting cancelled DownloadItems.  So I'll go
with it :-}.

[asanka, 2013/05/22 22:55:52]

Noted :)

       // If the download is no longer known to the DownloadManager, then it was
-      // removed after it was resumed. Ignore.
+      // removed after it was resumed. Ignore. If the download is cancelled
+      // while resuming, then also ignore the request.
       info->request_handle.CancelRequest();
       return NULL;
     }