Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 1495783002: Revert of mojo-apptests: Fix detecting failure when no test ran. (Closed)

Created:
5 years ago by sky
Modified:
5 years ago
Reviewers:
msw, sadrul
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mojo-apptests: Fix detecting failure when no test ran. (patchset #2 id:20001 of https://codereview.chromium.org/1499463002/ ) Reason for revert: Speculative revert as cq is failing in an unusual way when running mojo_apptests: 'module' object has no attribute 'should_start_xvfb' from https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/149295/steps/mojo_apptests%20%28without%20patch%29/logs/stdio Original issue's description: > mojo-apptests: Fix detecting failure when no test ran. > > BUG=none > R=msw@chromium.org > > Committed: https://crrev.com/c36c6282445549860ff359b3a9bc1515a8566e1f > Cr-Commit-Position: refs/heads/master@{#362825} TBR=msw@chromium.org,sadrul@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/914fe005f2cb4098132727c34332330058a87ba7 Cr-Commit-Position: refs/heads/master@{#362905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M mojo/tools/apptest_runner.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sky
Created Revert of mojo-apptests: Fix detecting failure when no test ran.
5 years ago (2015-12-03 04:36:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495783002/1
5 years ago (2015-12-03 04:37:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 04:40:00 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-03 04:41:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/914fe005f2cb4098132727c34332330058a87ba7
Cr-Commit-Position: refs/heads/master@{#362905}

Powered by Google App Engine
This is Rietveld 408576698