Roll WebKit DEPS from 45738 to 45840.

Roll WebKit DEPS from 45738 to 45840.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20589

[Dmitry Titov, 2009-07-13 22:51:44]

Build fixes... 
test_expectations.txt with updated results will be added when tests run through.

[Nate Chapin, 2009-07-13 22:58:57]

LGTM.

I'm trusting that this compiled still present in UndetectableHTMLCollection.idl
being removed from webkit.gyp.  It shouldn't cause a naming collision or
anything, but I figured I should ask.

[jam, 2009-07-13 22:59:23]

http://codereview.chromium.org/149575/diff/1/15
File chrome/common/ipc_message_macros.h (right):

http://codereview.chromium.org/149575/diff/1/15#newcode99
Line 99: #undef IPC_MESSAGE_ROUTED7
When the number of parameters gets this high, we send a struct instead of
creating another parameter.  Please stick to that guideline. 
IPC_MESSAGE_ROUTED6 shouldn't have been added in the first place.

[Nate Chapin, 2009-07-13 22:59:50]

On 2009/07/13 22:58:57, Nate Chapin wrote:
> LGTM.
> 
> I'm trusting that this compiled still present in
UndetectableHTMLCollection.idl
> being removed from webkit.gyp.  It shouldn't cause a naming collision or
> anything, but I figured I should ask.

Wow, total english fail on the first sentence.

"I'm trusting that this compiled with  UndetectableHTMLCollection.idl still
present in webkit.gyp."

Sorry about that.

[jam, 2009-07-15 22:21:03]

It's been nearly two days since this was checked in.  Given that it doesn't
conform to Chrome's guidelines regarding IPC usage, which were pointed out
at review time, the follow up patch should have been submitted that day or
the following one at the most.  To maintain the high quality of Chrome's
source code, all patches need to be held up to the same standard, including
rolling WebKit.
Thanks,
John

On Mon, Jul 13, 2009 at 3:59 PM, <jam@chromium.org> wrote:

>
> http://codereview.chromium.org/149575/diff/1/15
> File chrome/common/ipc_message_macros.h (right):
>
> http://codereview.chromium.org/149575/diff/1/15#newcode99
> Line 99: #undef IPC_MESSAGE_ROUTED7
> When the number of parameters gets this high, we send a struct instead
> of creating another parameter.  Please stick to that guideline.
> IPC_MESSAGE_ROUTED6 shouldn't have been added in the first place.
>
>
> http://codereview.chromium.org/149575
>

[darin (slow to review), 2009-07-15 22:48:01]

http://codereview.chromium.org/149575/diff/1/15
File chrome/common/ipc_message_macros.h (right):

http://codereview.chromium.org/149575/diff/1/15#newcode99
Line 99: #undef IPC_MESSAGE_ROUTED7
I'm just catching up on emails... I couldn't agree more!  Please undo this part
of the change.  Add a struct to worker_messages.h instead.  That's our standard
practice.  Thanks!  (see render_messages.h for examples and naming conventions
for these structs.)

[Dmitry Titov, 2009-07-15 23:03:52]

I couldn't agree more too. I'm just a bit swamped - there were several tests
disabled as a result of the merge, so I'm workign a queue of things.Right
now, I'm trying to enable back some selenium tests...

Since this is a style violation and not a breakage I figured it can be done
after tests are fixed. I've asked John to help but he seems not to have
cycles either :-(

Sorry that I can't do things faster, but WebKit merge sometimes leaves quite
a tail to be busy 2-3 days after.
Dmitry

On Wed, Jul 15, 2009 at 3:48 PM, <darin@chromium.org> wrote:

>
> http://codereview.chromium.org/149575/diff/1/15
> File chrome/common/ipc_message_macros.h (right):
>
> http://codereview.chromium.org/149575/diff/1/15#newcode99
> Line 99: #undef IPC_MESSAGE_ROUTED7
> I'm just catching up on emails... I couldn't agree more!  Please undo
> this part of the change.  Add a struct to worker_messages.h instead.
> That's our standard practice.  Thanks!  (see render_messages.h for
> examples and naming conventions for these structs.)
>
>
> http://codereview.chromium.org/149575
>

[darin (slow to review), 2009-07-15 23:06:42]

Totally understood...  I just didn't see a response, so I thought I'd send a
"ping"...  that it is on your post-merge cleanup list is all I care about
:-)
Thanks,
-Darin

On Wed, Jul 15, 2009 at 4:03 PM, Dmitry Titov <dimich@chromium.org> wrote:

> I couldn't agree more too. I'm just a bit swamped - there were several
> tests disabled as a result of the merge, so I'm workign a queue of
things.Right
> now, I'm trying to enable back some selenium tests...
>
> Since this is a style violation and not a breakage I figured it can be done
> after tests are fixed. I've asked John to help but he seems not to have
> cycles either :-(
>
> Sorry that I can't do things faster, but WebKit merge sometimes leaves
> quite a tail to be busy 2-3 days after.
> Dmitry
>
> On Wed, Jul 15, 2009 at 3:48 PM, <darin@chromium.org> wrote:
>
>>
>> http://codereview.chromium.org/149575/diff/1/15
>> File chrome/common/ipc_message_macros.h (right):
>>
>> http://codereview.chromium.org/149575/diff/1/15#newcode99
>> Line 99: #undef IPC_MESSAGE_ROUTED7
>> I'm just catching up on emails... I couldn't agree more!  Please undo
>> this part of the change.  Add a struct to worker_messages.h instead.
>> That's our standard practice.  Thanks!  (see render_messages.h for
>> examples and naming conventions for these structs.)
>>
>>
>> http://codereview.chromium.org/149575
>>
>
>

[jam, 2009-07-16 00:42:00]

Sounds good.  This is probably much easier than fixing tests, so if you get
bored of that and are looking for a break... :)

On Wed, Jul 15, 2009 at 4:03 PM, Dmitry Titov <dimich@chromium.org> wrote:

> I couldn't agree more too. I'm just a bit swamped - there were several
> tests disabled as a result of the merge, so I'm workign a queue of
things.Right
> now, I'm trying to enable back some selenium tests...
>
> Since this is a style violation and not a breakage I figured it can be done
> after tests are fixed. I've asked John to help but he seems not to have
> cycles either :-(
>
> Sorry that I can't do things faster, but WebKit merge sometimes leaves
> quite a tail to be busy 2-3 days after.
> Dmitry
>
> On Wed, Jul 15, 2009 at 3:48 PM, <darin@chromium.org> wrote:
>
>>
>> http://codereview.chromium.org/149575/diff/1/15
>> File chrome/common/ipc_message_macros.h (right):
>>
>> http://codereview.chromium.org/149575/diff/1/15#newcode99
>> Line 99: #undef IPC_MESSAGE_ROUTED7
>> I'm just catching up on emails... I couldn't agree more!  Please undo
>> this part of the change.  Add a struct to worker_messages.h instead.
>> That's our standard practice.  Thanks!  (see render_messages.h for
>> examples and naming conventions for these structs.)
>>
>>
>> http://codereview.chromium.org/149575
>>
>
>