Minimum implementation of ARC clipboard Bridge

chrome/browser/chromeos/arc/clipboard/arc_clipboard_manager.cc

Index: chrome/browser/chromeos/arc/clipboard/arc_clipboard_manager.cc
diff --git a/chrome/browser/chromeos/arc/clipboard/arc_clipboard_manager.cc b/chrome/browser/chromeos/arc/clipboard/arc_clipboard_manager.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2106404086d6005e351915cd848ead0b62e9cb14
--- /dev/null
+++ b/chrome/browser/chromeos/arc/clipboard/arc_clipboard_manager.cc
@@ -0,0 +1,65 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/arc/clipboard/arc_clipboard_manager.h"
+
+#include "base/logging.h"
+#include "base/strings/utf_string_conversions.h"
+#include "ui/base/clipboard/clipboard.h"
+#include "ui/base/clipboard/clipboard_types.h"
+#include "ui/base/clipboard/scoped_clipboard_writer.h"
+
+namespace chromeos {
+
+ArcClipboardManager::ArcClipboardManager() {
+  arc::ArcBridgeService* bridge_service = arc::ArcBridgeService::Get();

[jochen (gone - plz use gerrit), 2015/12/07 15:45:09]

please make this a ctor parameter so it can be mocked for unit tests

+  if (!bridge_service) {
+    LOG(ERROR) << "Bridge service is not available. Cannot initialize.";

[jochen (gone - plz use gerrit), 2015/12/07 15:45:09]

can this ever occur?

if yes, how will the user be notified about this?

also, no LOG

+    return;
+  }
+
+  bridge_service->AddObserver(this);
+  bridge_service->AddClipboardObserver(this);
+}
+
+ArcClipboardManager::~ArcClipboardManager() {
+  arc::ArcBridgeService* bridge_service = arc::ArcBridgeService::Get();
+  if (bridge_service) {
+    bridge_service->RemoveClipboardObserver(this);
+    bridge_service->RemoveObserver(this);
+  }
+}
+
+void ArcClipboardManager::OnSetClipboardContent(
+    const arc::ClipboardData& data) {
+  arc::ArcBridgeService* bridge_service = arc::ArcBridgeService::Get();

[elijahtaylor1, 2015/12/04 20:36:51]

you don't need bridge_service below, so you could remove this and the check, and
it should be impossible that you get this message without the service up anyway

[jochen (gone - plz use gerrit), 2015/12/07 15:45:09]

also, you should just store the service as a member 

+  if (!bridge_service) {
+    LOG(ERROR) << "Request to set clipboard content when bridge service is"
+               << " not ready.";
+    return;
+  }
+
+  ui::ScopedClipboardWriter writer(ui::CLIPBOARD_TYPE_COPY_PASTE);
+  writer.WriteText(base::UTF8ToUTF16(data.text));
+}
+
+void ArcClipboardManager::OnGetClipboardContent() {
+  arc::ArcBridgeService* bridge_service = arc::ArcBridgeService::Get();
+  if (!bridge_service) {

[elijahtaylor1, 2015/12/04 20:36:51]

maybe a CHECK?  This method should only be called from the bridge itself, so it
would be super unlikely this would be null

+    LOG(ERROR) << "Request to get clipboard content when bridge service is"
+               << " not ready.";
+    return;
+  }
+
+  base::string16 text;
+  ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread();
+  clipboard->ReadText(ui::CLIPBOARD_TYPE_COPY_PASTE, &text);
+
+  arc::ClipboardData result;
+  result.type = arc::ClipboardDataType::TEXT;
+  result.text = base::UTF16ToUTF8(text);
+  bridge_service->SendClipboardContentToAndroid(result);
+}
+
+}  // namespace chromeos