Minimum implementation of ARC clipboard Bridge

components/arc/clipboard/clipboard_bridge_impl.h

Index: components/arc/clipboard/clipboard_bridge_impl.h
diff --git a/components/arc/clipboard/clipboard_bridge_impl.h b/components/arc/clipboard/clipboard_bridge_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..f498b7b4f1c5450ee0badf83c9fdfad7f29cb42b
--- /dev/null
+++ b/components/arc/clipboard/clipboard_bridge_impl.h
@@ -0,0 +1,35 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.

[elijahtaylor1, 2015/12/15 01:17:05]

I think we've developed a bit of an anti-pattern in components/arc with these
impl.h files, and impls without tests.  I also think we're using the term Bridge
too much, though I'm not sure a better term... ClipboardService?
ClipboardManager? I don't know.

There are two things we should do IMO:

1) either find a way to test this implementation (preffered) or get rid of the
ClipboardBridge / ClipboardBridgeImpl split

2) if you keep this split, clipboard_bridge_impl.h can be inlined in
clipboard_bridge_impl.cc

[cnwan, 2015/12/21 11:18:01]

I am OK with Service/Manager/Bridge/... 
I picked 'XXXBridge' just to be consistent with other implementations in
components/arc (input/notification/settings).

If I had to choose, I would pick XXXService since we have a ServiceManager which
in theory manages other arc-related services such as
InputService/ClipboardService/SettingsService/... but for now I am a bit towards
'the consistent side'.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_ARC_CLIPBOARD_CLIPBOARD_BRIDGE_IMPL_H_
+#define COMPONENTS_ARC_CLIPBOARD_CLIPBOARD_BRIDGE_IMPL_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "components/arc/arc_bridge_service.h"
+#include "components/arc/clipboard/clipboard_bridge.h"
+#include "components/arc/common/arc_bridge.mojom.h"
+
+namespace arc {
+
+class ClipboardBridgeImpl : public ClipboardBridge,
+                            public ArcBridgeService::ClipboardObserver {

[Luis Héctor Chávez, 2015/12/16 23:16:23]

Can you make this inherit ArcBridgeService::Observer and arc::ClipboardHost
instead?

+ public:
+  explicit ClipboardBridgeImpl(ArcBridgeService* bridge_service);
+  ~ClipboardBridgeImpl() override;
+
+  // Implements ArcBridgeService::ClipboardObserver:
+  void OnSetClipboardContent(const std::string& text) override;
+  void OnGetClipboardContent() override;
+
+ private:
+  ArcBridgeService* bridge_service_;
+
+  DISALLOW_COPY_AND_ASSIGN(ClipboardBridgeImpl);
+};
+
+}  // namespace arc
+
+#endif  // COMPONENTS_ARC_CLIPBOARD_CLIPBOARD_BRIDGE_IMPL_H_