Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 1495723003: Reland of Ship promise rejection events (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Ship promise rejection events (patchset #1 id:1 of https://codereview.chromium.org/1498703002/ ) Reason for revert: i'll disable the test instead Original issue's description: > Revert of Ship promise rejection events (patchset #2 id:20001 of https://codereview.chromium.org/1496453002/ ) > > Reason for revert: > This is breaking SystemWebViewShellLayoutTests on Android Webview L. See crbug/564765. > > Original issue's description: > > Ship promise rejection events > > > > I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/AmChp_uVpXU > > > > BUG=495801 > > R=philipj@opera.com > > > > Committed: https://crrev.com/98bd85306f3a170fa465c3f5a754ac2519a36be1 > > Cr-Commit-Position: refs/heads/master@{#362695} > > TBR=philipj@opera.com,jochen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=495801 > > Committed: https://crrev.com/f3e241833fad43bec928922e949fa8cd2f4d84ff > Cr-Commit-Position: refs/heads/master@{#362891} TBR=philipj@opera.com,ianwen@chromium.org,khushalsagar@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495801 Committed: https://crrev.com/d422006e4e8d85ea9bbd37bbd08d70ce3a2484dd Cr-Commit-Position: refs/heads/master@{#362932}

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
jochen (gone - plz use gerrit)
Created Reland of Ship promise rejection events
5 years ago (2015-12-03 07:58:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495723003/1
5 years ago (2015-12-03 07:59:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 08:00:28 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-03 08:01:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d422006e4e8d85ea9bbd37bbd08d70ce3a2484dd
Cr-Commit-Position: refs/heads/master@{#362932}

Powered by Google App Engine
This is Rietveld 408576698