[Media Router] Check MediaRouterDialogControllerImpl only sets toolbar MediaRouterAction.

chrome/browser/ui/toolbar/media_router_action_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "chrome/browser/extensions/browser_action_test_util.h"
+#include "chrome/browser/extensions/extension_action_test_util.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/toolbar/media_router_action.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_delegate.h"
 #include "chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h"
 #include "chrome/browser/ui/webui/media_router/media_router_test.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/test/test_utils.h"
 #include "grit/theme_resources.h"
@@ skipping 12 matching lines @@
 
   MOCK_CONST_METHOD0(GetCurrentWebContents, WebContents*());
   MOCK_METHOD0(UpdateState, void());
   MOCK_CONST_METHOD0(IsMenuRunning, bool());
   MOCK_METHOD1(OnPopupShown, void(bool by_user));
   MOCK_METHOD0(OnPopupClosed, void());
 };
 
 class TestMediaRouterAction : public MediaRouterAction {
  public:
-  explicit TestMediaRouterAction(Browser* browser)
-      : MediaRouterAction(browser),
+  TestMediaRouterAction(Browser* browser,
+                        ToolbarActionsBar* toolbar_actions_bar)
+      : MediaRouterAction(browser, toolbar_actions_bar),
         controller_(nullptr),
         platform_delegate_(nullptr) {}
   ~TestMediaRouterAction() override {}
 
   void SetMediaRouterDialogController(
       MediaRouterDialogControllerImpl* controller) {
     DCHECK(controller);
     controller_ = controller;
   }
 
  private:
   MediaRouterDialogControllerImpl* GetMediaRouterDialogController()
       override {
     return controller_;
   }
 
   MediaRouterActionPlatformDelegate* GetPlatformDelegate() override {
     return platform_delegate_;
   }
 
   MediaRouterDialogControllerImpl* controller_;
   MediaRouterActionPlatformDelegate* platform_delegate_;
 };
 
 class MediaRouterActionUnitTest : public MediaRouterTest {
  public:
   MediaRouterActionUnitTest()
-      : fake_issue_notification_(media_router::Issue(
+      : toolbar_model_(nullptr),
+        fake_issue_notification_(media_router::Issue(
             "title notification",
             "message notification",
             media_router::IssueAction(media_router::IssueAction::TYPE_DISMISS),
             std::vector<media_router::IssueAction>(),
             "route_id",
             media_router::Issue::NOTIFICATION,
             false,
             std::string())),
         fake_issue_warning_(
             media_router::Issue("title warning",
@@ skipping 23 matching lines @@
         idle_icon_(ui::ResourceBundle::GetSharedInstance().GetImageNamed(
             IDR_MEDIA_ROUTER_IDLE_ICON)),
         warning_icon_(ui::ResourceBundle::GetSharedInstance().GetImageNamed(
             IDR_MEDIA_ROUTER_WARNING_ICON)) {}
 
   ~MediaRouterActionUnitTest() override {}
 
   // MediaRouterTest:
   void SetUp() override {
     MediaRouterTest::SetUp();
-    action_.reset(new TestMediaRouterAction(browser()));
+    toolbar_model_ = extensions::extension_action_test_util::
+        CreateToolbarModelForProfileWithoutWaitingForReady(profile());
+
+    // browser() will only be valid once BrowserWithTestWindowTest::SetUp()
+    // has run.
+    browser_action_test_util_.reset(
+        new BrowserActionTestUtil(browser(), false));
+    action_.reset(
+        new TestMediaRouterAction(
+            browser(),
+            browser_action_test_util_->GetToolbarActionsBar()));
   }
 
   void TearDown() override {
+    browser_action_test_util_.reset();
     action_.reset();
     MediaRouterTest::TearDown();
   }
 
   TestMediaRouterAction* action() { return action_.get(); }
   const media_router::Issue* fake_issue_notification() {
     return &fake_issue_notification_;
   }
   const media_router::Issue* fake_issue_warning() {
     return &fake_issue_warning_;
   }
   const media_router::Issue* fake_issue_fatal() {
     return &fake_issue_fatal_;
   }
   const gfx::Image active_icon() { return active_icon_; }
   const gfx::Image error_icon() { return error_icon_; }
   const gfx::Image idle_icon() { return idle_icon_; }
   const gfx::Image warning_icon() { return warning_icon_; }
 
  private:
+  // A BrowserActionTestUtil object constructed with the associated
+  // ToolbarActionsBar.
+  scoped_ptr<BrowserActionTestUtil> browser_action_test_util_;
+
   scoped_ptr<TestMediaRouterAction> action_;
 
+  // The associated ToolbarActionsModel (owned by the keyed service setup).
+  ToolbarActionsModel* toolbar_model_;
+
   // Fake Issues.
   const media_router::Issue fake_issue_notification_;
   const media_router::Issue fake_issue_warning_;
   const media_router::Issue fake_issue_fatal_;
 
   // Fake Sources, used for the Routes.
   const media_router::MediaSource fake_source1_;
   const media_router::MediaSource fake_source2_;
 
   // Cached images.
@@ skipping 146 matching lines @@
 
   EXPECT_CALL(*mock_delegate, OnPopupClosed()).Times(1);
   dialog_controller_->HideMediaRouterDialog();
 
   EXPECT_CALL(*mock_delegate, OnPopupShown(true)).Times(1);
   dialog_controller_->CreateMediaRouterDialog();
 
   EXPECT_CALL(*mock_delegate, OnPopupClosed()).Times(1);
   dialog_controller_->HideMediaRouterDialog();
 }