Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 149565: Allow dragging text/url content out of the browser. Dragging back in not yet ... (Closed)

Created:
11 years, 5 months ago by pink (ping after 24hrs)
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Allow dragging text/url content out of the browser. Dragging back in not yet implemented. BUG=13155 TEST=dragging urls and selected text to other apps, the desktop, or the Dock should work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20619

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+1093 lines, -8 lines) Patch
M chrome/browser/tab_contents/tab_contents_view_mac.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 4 chunks +99 lines, -7 lines 8 comments Download
M chrome/chrome.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/mozilla/include/NSPasteboard+Utils.h View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/mozilla/include/NSPasteboard+Utils.mm View 1 chunk +278 lines, -0 lines 0 comments Download
A third_party/mozilla/include/NSString+Utils.h View 1 chunk +101 lines, -0 lines 0 comments Download
A third_party/mozilla/include/NSString+Utils.m View 1 chunk +362 lines, -0 lines 0 comments Download
A third_party/mozilla/include/NSURL+Utils.h View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/mozilla/include/NSURL+Utils.m View 1 chunk +135 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pink (ping after 24hrs)
11 years, 5 months ago (2009-07-13 21:02:06 UTC) #1
stuartmorgan
LGTM, just small nits. http://codereview.chromium.org/149565/diff/1003/29 File chrome/browser/tab_contents/tab_contents_view_mac.mm (right): http://codereview.chromium.org/149565/diff/1003/29#newcode85 Line 85: // populated in decending ...
11 years, 5 months ago (2009-07-13 21:43:32 UTC) #2
pink (ping after 24hrs)
11 years, 5 months ago (2009-07-13 21:57:56 UTC) #3
http://codereview.chromium.org/149565/diff/1003/29
File chrome/browser/tab_contents/tab_contents_view_mac.mm (right):

http://codereview.chromium.org/149565/diff/1003/29#newcode85
Line 85: // populated in decending order of richness.
On 2009/07/13 21:43:32, stuartmorgan wrote:
> Isn't HTML richer than a URL?

Done.

http://codereview.chromium.org/149565/diff/1003/29#newcode143
Line 143: slideBack:YES];
On 2009/07/13 21:43:32, stuartmorgan wrote:
> Isn't our style either one line, or one argument per line aligned at the :?

Done.

http://codereview.chromium.org/149565/diff/1003/29#newcode373
Line 373: 
On 2009/07/13 21:43:32, stuartmorgan wrote:
> Why is there an empty and TODO-less method?

Done.

http://codereview.chromium.org/149565/diff/1003/29#newcode381
Line 381: // TODO(pinkerton): Force drops to be rejected until that's hooked up.
On 2009/07/13 21:43:32, stuartmorgan wrote:
> Seems like this is describing the current behavior, so it's confusing as a
TODO;
> replace with a description of what should be done eventually.

Done.

Powered by Google App Engine
This is Rietveld 408576698