Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 1495643002: Adds an IOSWebViewTypeParam() method to SearchTermsData. (Closed)

Created:
5 years ago by rohitrao (ping after 24h)
Modified:
5 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds an IOSWebViewTypeParam() method to SearchTermsData. This method returns the type of the iOS webview currently in use, formatted as a cgi param suitable for appending to omnibox queries. This CL also updates the corresponding experimental flags methods to cache the current experiment state, since the state will soon be queried often when constructing omnibox results. BUG=551851 TEST=None Committed: https://crrev.com/4b79d938a6ee4361efd6978a123dfcf92f594a87 Cr-Commit-Position: refs/heads/master@{#362773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -27 lines) Patch
M components/search_engines/search_terms_data.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/search_engines/search_terms_data.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 3 chunks +63 lines, -27 lines 0 comments Download
M ios/chrome/browser/search_engines/ui_thread_search_terms_data.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/search_engines/ui_thread_search_terms_data.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rohitrao (ping after 24h)
5 years ago (2015-12-02 18:23:31 UTC) #2
sdefresne
lgtm
5 years ago (2015-12-02 18:47:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495643002/1
5 years ago (2015-12-02 18:56:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 19:37:45 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 19:39:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b79d938a6ee4361efd6978a123dfcf92f594a87
Cr-Commit-Position: refs/heads/master@{#362773}

Powered by Google App Engine
This is Rietveld 408576698