Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1495633002: Removed support deprecated (//@|/*@) source(URL|MappingURL)= (Closed)

Created:
5 years ago by kozy
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed support deprecated (//@|/*@) source(URL|MappingURL)= LOG=Y BUG=chromium:558998 R=yangguo@chromium.org Committed: https://crrev.com/cab2512a5ec87da12f9b8533661df330af732cb9 Cr-Commit-Position: refs/heads/master@{#32528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -31 lines) Patch
M include/v8.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/js/messages.js View 1 chunk +3 lines, -4 lines 0 comments Download
M src/parsing/scanner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M test/mjsunit/regress/regress-conditional-position.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-109362.js View 2 chunks +10 lines, -10 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-481896.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-517592.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/stack-traces.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
kozy
Reland of https://codereview.chromium.org/1474543005/ . Tests are prepared in https://codereview.chromium.org/1483053003/
5 years ago (2015-12-02 17:44:42 UTC) #1
Yang
On 2015/12/02 17:44:42, kozyatinskiy wrote: > Reland of https://codereview.chromium.org/1474543005/ . > Tests are prepared in ...
5 years ago (2015-12-02 17:50:27 UTC) #2
Yang
On 2015/12/02 17:44:42, kozyatinskiy wrote: > Reland of https://codereview.chromium.org/1474543005/ . > Tests are prepared in ...
5 years ago (2015-12-02 17:50:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495633002/1
5 years ago (2015-12-02 18:25:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495633002/1
5 years ago (2015-12-02 19:51:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 19:53:10 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-02 19:53:57 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cab2512a5ec87da12f9b8533661df330af732cb9
Cr-Commit-Position: refs/heads/master@{#32528}

Powered by Google App Engine
This is Rietveld 408576698