chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm - Issue 1495623008: Polish Tabstrip and Overlay Issues in Fullscreen

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

Issue 1495623008: Polish Tabstrip and Overlay Issues in Fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SSLCertificateViewerCocoaTest fixed Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/certificate_viewer_mac.mm ('k') | chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "chrome/browser/certificate_viewer.h"	5 #import "chrome/browser/certificate_viewer.h"

6	6

7 #include "chrome/browser/ui/browser.h"	7 #include "chrome/browser/ui/browser.h"

8 #include "chrome/browser/ui/browser_commands.h"	8 #include "chrome/browser/ui/browser_commands.h"

9 #include "chrome/browser/ui/cocoa/certificate_viewer_mac.h"	9 #include "chrome/browser/ui/cocoa/certificate_viewer_mac.h"

10 #include "chrome/browser/ui/tabs/tab_strip_model.h"	10 #include "chrome/browser/ui/tabs/tab_strip_model.h"

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64	64

65 content::RunAllPendingInMessageLoop();	65 content::RunAllPendingInMessageLoop();

66	66

67 NSWindow* sheetWindow = [[viewer overlayWindow] attachedSheet];	67 NSWindow* sheetWindow = [[viewer overlayWindow] attachedSheet];

68 NSRect sheetFrame = [sheetWindow frame];	68 NSRect sheetFrame = [sheetWindow frame];

69 EXPECT_EQ(1.0, [sheetWindow alphaValue]);	69 EXPECT_EQ(1.0, [sheetWindow alphaValue]);

70	70

71 // Switch to another tab and verify that the sheet is hidden.	71 // Switch to another tab and verify that the sheet is hidden.

72 AddBlankTabAndShow(browser());	72 AddBlankTabAndShow(browser());

73 EXPECT_EQ(0.0, [sheetWindow alphaValue]);	73 EXPECT_EQ(0.0, [sheetWindow alphaValue]);

74 EXPECT_NSEQ(ui::kWindowSizeDeterminedLater, [sheetWindow frame]);	74 EXPECT_NSEQ(sheetFrame, [sheetWindow frame]);

75	75

76 // Switch back and verify that the sheet is shown.	76 // Switch back and verify that the sheet is shown.

77 chrome::SelectNumberedTab(browser(), 0);	77 chrome::SelectNumberedTab(browser(), 0);

78 EXPECT_EQ(1.0, [sheetWindow alphaValue]);	78 EXPECT_EQ(1.0, [sheetWindow alphaValue]);

79 EXPECT_NSEQ(sheetFrame, [sheetWindow frame]);	79 EXPECT_NSEQ(sheetFrame, [sheetWindow frame]);

80 }	80 }

OLD	NEW