Polish Tabstrip and Overlay Issues in Fullscreen

chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h"
 
 #include <QuartzCore/QuartzCore.h>
 
 #include "base/mac/bind_objc_block.h"
 #include "base/mac/foundation_util.h"
@@ skipping 95 matching lines @@
 
   // Whether |primaryWindow_| was opaque before the transition began.
   BOOL primaryWindowInitialOpaque_;
 
   // The initial anchor point of the root layer.
   CGPoint initialRootAnchorPoint_;
 
   // The initial origin of the content view.
   NSPoint initialContentViewOrigin_;
 
-  // The initial value of the content view's autoresizeSubviews property.
-  BOOL initialContentViewAutoresizesSubviews_;
-
   // Whether the instance is in the process of changing the size of
   // |primaryWindow_|.
   BOOL changingPrimaryWindowSize_;
 
   // The frame of the |primaryWindow_| before it starts the transition.
   NSRect initialFrame_;
 
   // The frame that |primaryWindow_| is expected to have after the transition
   // is finished.
   NSRect finalFrame_;
@@ skipping 195 matching lines @@
     initialContentViewOrigin_ = [[primaryWindow_ contentView] frame].origin;
     initialRootAnchorPoint_ = root.anchorPoint;
 
     NSPoint contentViewOrigin =
         [self pointRelativeToCurrentScreen:finalFrame_.origin];
     NSRect relativeContentFinalFrame =
         NSMakeRect(contentViewOrigin.x, contentViewOrigin.y,
                    finalFrame_.size.width, finalFrame_.size.height);
     [primaryWindow_ forceContentViewFrame:relativeContentFinalFrame];
 
-    // In OSX 10.11, when the NSFullScreenWindowMask is added or removed,
-    // the window's frame and layer changes slightly which causes a janky
-    // movement. As a result, we should disable the content view's autoresize
-    // at the beginning of the animation and set it back to its original value
-    // at the end of the animation.
-    initialContentViewAutoresizesSubviews_ = [contentView autoresizesSubviews];
-    [contentView setAutoresizesSubviews:NO];
-
     fullscreenTabStripBackgroundView_.reset(
         [[FullscreenTabStripBackgroundView alloc]
             initWithFrame:finalFrame_
                background:primaryWindowInitialBackgroundColor_]);
     [fullscreenTabStripBackgroundView_ setFrameOrigin:NSZeroPoint];
     [contentView addSubview:fullscreenTabStripBackgroundView_.get()
                  positioned:NSWindowBelow
                  relativeTo:nil];
 
     [tabStripBackgroundView_ setHidden:YES];
@@ skipping 132 matching lines @@
       root.anchorPoint = initialRootAnchorPoint_;
 
       NSUInteger styleMask =
           ([primaryWindow_ styleMask] & ~NSFullScreenWindowMask) |
           NSTexturedBackgroundWindowMask;
       [primaryWindow_ setStyleMask:styleMask];
 
       NSView* content = [primaryWindow_ contentView];
       [content setFrameOrigin:initialContentViewOrigin_];
       [self changePrimaryWindowToFinalFrame];
-      [content setAutoresizesSubviews:initialContentViewAutoresizesSubviews_];
 
       [tabStripBackgroundView_ setHidden:NO];
       [fullscreenTabStripBackgroundView_ removeFromSuperview];
     }
 
     // Checks if the contentView size is correct.
     NSSize expectedSize = finalFrame_.size;
     NSView* content = [primaryWindow_ contentView];
     DCHECK_EQ(NSHeight(content.frame), expectedSize.height);
     DCHECK_EQ(NSWidth(content.frame), expectedSize.width);
@@ skipping 12 matching lines @@
   return [[[window contentView] superview] layer];
 }
 
 - (NSPoint)pointRelativeToCurrentScreen:(NSPoint)point {
   NSRect screenFrame = [[primaryWindow_ screen] frame];
   return NSMakePoint(point.x - screenFrame.origin.x,
                      point.y - screenFrame.origin.y);
 }
 
 @end