Polish Tabstrip and Overlay Issues in Fullscreen

chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h"
 
 #include <map>
 
 #include "base/logging.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h"
@@ skipping 180 matching lines @@
 
   // Show the sheet.
   [info showSheet];
 }
 
 - (void)hideSheet {
   [[self findSheetInfoForParentView:activeView_] hideSheet];
   activeView_.reset();
 }
 
+- (void)hideSheetForFullscreenTransition {
+  if (ConstrainedWindowSheetInfo* sheetInfo =
+          [self findSheetInfoForParentView:activeView_]) {
+    [sheetInfo hideSheet];
+    isSheetHiddenForFullscreen_ = YES;
+  }
+}
+
+- (void)unhideSheetForFullscreenTransition {
+  isSheetHiddenForFullscreen_ = NO;
+  if (ConstrainedWindowSheetInfo* sheetInfo =
+          [self findSheetInfoForParentView:activeView_])
+    [self showSheet:[sheetInfo sheet] forParentView:activeView_];

[Robert Sesek, 2015/12/04 17:56:30]

nit: needs {} since the condition is multi-line

[spqchan, 2015/12/07 18:27:52]

Done.

+}
+
 - (NSPoint)originForSheet:(id<ConstrainedWindowSheet>)sheet
            withWindowSize:(NSSize)size {
   ConstrainedWindowSheetInfo* info = [self findSheetInfoForSheet:sheet];
   DCHECK(info);
   NSRect containerRect =
       [self overlayWindowFrameForParentView:[info parentView]];
   return [self originForSheetSize:size inContainerRect:containerRect];
 }
 
 - (void)closeSheet:(id<ConstrainedWindowSheet>)sheet {
@@ skipping 49 matching lines @@
 
   // Delete this instance.
   [g_sheetControllers removeObjectForKey:GetKeyForParentWindow(parentWindow_)];
   if (![g_sheetControllers count]) {
     [g_sheetControllers release];
     g_sheetControllers = nil;
   }
 }
 
 - (void)onParentWindowSizeDidChange:(NSNotification*)note {
+  if (isSheetHiddenForFullscreen_)
+    return;
+
   [self updateSheetPosition:activeView_];
 }
 
 - (void)updateSheetPosition:(NSView*)parentView {
   ConstrainedWindowSheetInfo* info =
       [self findSheetInfoForParentView:parentView];
   if (!info)
     return;
 
   NSRect rect = [self overlayWindowFrameForParentView:parentView];
@@ skipping 54 matching lines @@
   if ([activeView_ isEqual:[info parentView]])
     activeView_.reset();
 
   [parentWindow_ removeChildWindow:[info overlayWindow]];
   [[info sheet] closeSheetWithAnimation:withAnimation];
   [[info overlayWindow] close];
   [sheets_ removeObject:info];
 }
 
 @end