Polish Tabstrip and Overlay Issues in Fullscreen

chrome/browser/ui/cocoa/browser_window_controller_private.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_
 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/browser_window_layout.h"
 #import "chrome/browser/ui/cocoa/presentation_mode_controller.h"
@@ skipping 162 matching lines @@
 - (PermissionBubbleManager*)permissionBubbleManager;
 
 #if defined(MAC_OS_X_VERSION_10_7) && \
     MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_7
 // Redeclare some methods from NSWindowDelegate to suppress
 // -Wpartial-availability warnings.
 - (void)windowDidEnterFullScreen:(NSNotification*)notification;
 - (void)windowDidExitFullScreen:(NSNotification*)notification;
 - (void)windowWillExitFullScreen:(NSNotification*)notification;
 
+// Hides or unhides the sheet for fullscreen transition. The sheet should be

[Robert Sesek, 2015/12/04 17:56:30]

"the sheet" -> "any modal sheet" (or even more specific if possible)

[spqchan, 2015/12/07 18:27:52]

Done.

+// hidden at the beginning and then shown at the end.
+- (void)hideSheetForFullscreenTransition:(BOOL)shoudHide;

[Robert Sesek, 2015/12/04 17:56:30]

What is |shouldHide| for? Maybe this should be
|setSheetHiddenForFullscreenTransition:| to make it more clear.

[spqchan, 2015/12/07 18:27:52]

Done.

+
 // Adjusts the UI and destroys the exit bubble when we are exiting fullscreen.
 - (void)adjustUIForExitingFullscreen;
 
 // Determines the appropriate sliding fullscreen style and adjusts the UI to
 // it when we are entering fullscreen.
 - (void)adjustUIForEnteringFullscreen;
 
 #endif
 
 @end  // @interface BrowserWindowController(Private)
 
 #endif  // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_