Make BrowserTest.ThirtyFourTabs not-flaky

chrome/browser/browser_browsertest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "app/l10n_util.h"
+#include "base/sys_info.h"
 #include "chrome/browser/app_modal_dialog.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/page_transition_types.h"
 #include "chrome/test/in_process_browser_test.h"
 #include "chrome/test/ui_test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
@@ skipping 73 matching lines @@
   EXPECT_EQ(0, browser()->selected_index());
   TabContents* second_tab = browser()->GetTabContentsAt(1);
   ASSERT_TRUE(second_tab);
   second_tab->render_view_host()->ExecuteJavascriptInWebFrame(L"",
       L"alert('Activate!');");
   AppModalDialog* alert = ui_test_utils::WaitForAppModalDialog();
   alert->CloseModalDialog();
   EXPECT_EQ(2, browser()->tab_count());
   EXPECT_EQ(1, browser()->selected_index());
 }
+
+// Create 34 tabs and verify that a lot of processes have been created. The
+// exact number of processes depends on the amount of memory. Previously we
+// had a hard limit of 31 processes and this test is mainly directed at
+// verifying that we don't crash when we pass this limit.
+IN_PROC_BROWSER_TEST_F(BrowserTest, ThirtyFourTabs) {
+  GURL url(ui_test_utils::GetTestUrl(L".", L"title2.html"));
+
+  // There is one initial tab.
+  for (int ix = 0; ix != 33; ++ix) {
+    browser()->AddTabWithURL(url, GURL(), PageTransition::TYPED,
+                             true, 0, false, NULL);
+  }
+  EXPECT_EQ(34, browser()->tab_count());
+
+  // See browser\renderer_host\render_process_host.cc for the algorithm to
+  // decide how many processes to create.
+  if (base::SysInfo::AmountOfPhysicalMemoryMB() >= 2048) {
+    EXPECT_GE(RenderProcessHost::size(), 24U);
+  } else {
+    EXPECT_LE(RenderProcessHost::size(), 23U);
+  }
+}