[Resumption 6/11] Add a RESUMING_INTERNAL state to DownloadItem.

content/browser/download/download_item_impl.h

Index: content/browser/download/download_item_impl.h
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h
index 083a1591ab46961772d844a62fc0e199b27c90fe..349e8713986d1f1042f550db572836dc563a3510 100644
--- a/content/browser/download/download_item_impl.h
+++ b/content/browser/download/download_item_impl.h
@@ -234,9 +234,13 @@ class CONTENT_EXPORT DownloadItemImpl
     CANCELLED_INTERNAL,
 
     // An error has interrupted the download.
-    // Only incoming transition IN_PROGRESS->
+    // Only incoming transitions IN_PROGRESS-> and RESUMING_INTERNAL.

[Randy Smith (Not in Mondays), 2013/05/09 01:00:57]

I don't actually remember how I was thinking of the transition syntax I used
here (which means you're welcome to change it to something else if you think
it's confusing), but this looks inconsistent.  If you keep this syntax, either
add a --> after the RESUMING_INTERNAL, or put the RESUMING_INTERNAL next to the
IN_PROGRESS so that the existing arrow can do double duty?

Alternatively, you could do a transition summary at the beginning of this enum
in either transition table form, or just listing all possible transitions.

[asanka, 2013/05/09 16:54:33]

I added notes listing all the transitions. Let me know if it's not clear.

The transitions weren't linear enough for a single comment at the top. :-/

     INTERRUPTED_INTERNAL,
 
+    // A request to resume this interrupted download is in progress.
+    // Only incoming transition INTERRUPTED_INTERNAL.
+    RESUMING_INTERNAL,
+
     MAX_DOWNLOAD_INTERNAL_STATE,
   };
 
@@ -297,6 +301,9 @@ class CONTENT_EXPORT DownloadItemImpl
   // is completed.
   void Completed();
 
+  // Callback invoked when the URLRequest for a download resumption has started.
+  void OnResumeRequestStarted(DownloadItem* item, net::Error error);
+
   // Helper routines -----------------------------------------------------------
 
   // Indicate that an error has occurred on the download.