Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 1495473002: [es6] correctly handle object wrappers in JSON.stringify. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] correctly handle object wrappers in JSON.stringify. R=bmeurer@chromium.org BUG=v8:4581 LOG=N Committed: https://crrev.com/62dcf2fab65574cccf5c78b53ec35089632d8f6a Cr-Commit-Position: refs/heads/master@{#32494}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, add tests, address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M src/json-stringifier.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 1 chunk +13 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/simd.js View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
5 years ago (2015-12-02 07:42:35 UTC) #1
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/1495473002/diff/1/src/json-stringifier.h File src/json-stringifier.h (right): https://codereview.chromium.org/1495473002/diff/1/src/json-stringifier.h#newcode401 src/json-stringifier.h:401: CHECK(!object->IsAccessCheckNeeded() && !object->IsJSGlobalProxy()); Nit: Please turn ...
5 years ago (2015-12-02 07:43:38 UTC) #2
Yang
https://codereview.chromium.org/1495473002/diff/1/src/json-stringifier.h File src/json-stringifier.h (right): https://codereview.chromium.org/1495473002/diff/1/src/json-stringifier.h#newcode401 src/json-stringifier.h:401: CHECK(!object->IsAccessCheckNeeded() && !object->IsJSGlobalProxy()); On 2015/12/02 07:43:38, Benedikt Meurer wrote: ...
5 years ago (2015-12-02 08:00:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495473002/20001
5 years ago (2015-12-02 08:00:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 08:43:31 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-02 08:44:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62dcf2fab65574cccf5c78b53ec35089632d8f6a
Cr-Commit-Position: refs/heads/master@{#32494}

Powered by Google App Engine
This is Rietveld 408576698