Calling gen_pron_pass() for generating password only once and Force Fixing it if needed.

Generating the Password using gen_pron_pass() and if it is not conforming then
force fixing it. No need to call gen_pron_pass() 10 times and then varifying
generated Password. As gen_pron_pass() doesn't guarantee that it includes all
of the type given in mode , so anyways we need to force fix it.

BUG=503044
Committed: https://crrev.com/88980864bcee9b92ad25beb4f3154b1b6e88acee
Cr-Commit-Position: refs/heads/master@{#362694}

[Deepak, 2015-12-02 06:30:14]

Description was changed from

==========
Generating the Password using gen_pron_pass() and if it is not conforming then
force fixing it. No need to call gen_pron_pass() 10 times and then varifying
generated Password. As gen_pron_pass() doesn't guarantee that it includes all of
the type given in mode , so anyways we need to force fix it.

BUG=503044
==========

to

==========
Generating the Password using gen_pron_pass() and if it is not conforming then
force fixing it. No need to call gen_pron_pass() 10 times and then varifying
generated Password. As gen_pron_pass() doesn't guarantee that it includes all of
the type given in mode , so anyways we need to force fix it.

BUG=503044
==========

[Deepak, 2015-12-02 10:56:25]

Description was changed from

==========
Generating the Password using gen_pron_pass() and if it is not conforming then
force fixing it. No need to call gen_pron_pass() 10 times and then varifying
generated Password. As gen_pron_pass() doesn't guarantee that it includes all of
the type given in mode , so anyways we need to force fix it.

BUG=503044
==========

to

==========
Generating the Password using gen_pron_pass() and if it is not conforming then
force fixing it. No need to call gen_pron_pass() 10 times and then varifying
generated Password. As gen_pron_pass() doesn't guarantee that it includes all
of the type given in mode , so anyways we need to force fix it.

BUG=503044
==========

[Deepak, 2015-12-02 10:57:12]

deepak.m1@samsung.com changed reviewers:
+ gcasto@google.com, vabr@chromium.org

[Deepak, 2015-12-02 10:57:12]

PTAL

[Deepak, 2015-12-02 10:57:36]

deepak.m1@samsung.com changed reviewers:
+ gcasto@chromium.org
- gcasto@google.com

[vabr (Chromium), 2015-12-02 11:43:09]

LGTM with a comment.

Thanks!
Vaclav

https://codereview.chromium.org/1495463002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/password_generator.cc (right):

https://codereview.chromium.org/1495463002/diff/1/components/autofill/core/br...
components/autofill/core/browser/password_generator.cc:96: std::string
str_password(password);
Please move this just above line 93, then you can remove 2 more std::string
creations by using str_password:

std::string str_password(password);
if (VerifyPassword(str_password))
  return str_password;

[Deepak, 2015-12-02 12:51:18]

@vabr
Thanks for review.
Changes done as suggested.

https://codereview.chromium.org/1495463002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/password_generator.cc (right):

https://codereview.chromium.org/1495463002/diff/1/components/autofill/core/br...
components/autofill/core/browser/password_generator.cc:96: std::string
str_password(password);
On 2015/12/02 11:43:09, vabr (Chromium) wrote:
> Please move this just above line 93, then you can remove 2 more std::string
> creations by using str_password:
> 
> std::string str_password(password);
> if (VerifyPassword(str_password))
>   return str_password;

Done.

[Deepak, 2015-12-02 12:51:25]

The CQ bit was checked by deepak.m1@samsung.com

[Deepak, 2015-12-02 12:51:25]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1495463002/#ps20001
(title: "Changes as per review comments.")

[commit-bot: I haz the power, 2015-12-02 12:51:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1495463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1495463002/20001

[vabr (Chromium), 2015-12-02 12:58:33]

lgtm

[commit-bot: I haz the power, 2015-12-02 13:45:01]

Description was changed from

==========
Generating the Password using gen_pron_pass() and if it is not conforming then
force fixing it. No need to call gen_pron_pass() 10 times and then varifying
generated Password. As gen_pron_pass() doesn't guarantee that it includes all
of the type given in mode , so anyways we need to force fix it.

BUG=503044
==========

to

==========
Generating the Password using gen_pron_pass() and if it is not conforming then
force fixing it. No need to call gen_pron_pass() 10 times and then varifying
generated Password. As gen_pron_pass() doesn't guarantee that it includes all
of the type given in mode , so anyways we need to force fix it.

BUG=503044
==========

[commit-bot: I haz the power, 2015-12-02 13:45:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-02 13:45:50]

Description was changed from

==========
Generating the Password using gen_pron_pass() and if it is not conforming then
force fixing it. No need to call gen_pron_pass() 10 times and then varifying
generated Password. As gen_pron_pass() doesn't guarantee that it includes all
of the type given in mode , so anyways we need to force fix it.

BUG=503044
==========

to

==========
Generating the Password using gen_pron_pass() and if it is not conforming then
force fixing it. No need to call gen_pron_pass() 10 times and then varifying
generated Password. As gen_pron_pass() doesn't guarantee that it includes all
of the type given in mode , so anyways we need to force fix it.

BUG=503044

Committed: https://crrev.com/88980864bcee9b92ad25beb4f3154b1b6e88acee
Cr-Commit-Position: refs/heads/master@{#362694}
==========

[commit-bot: I haz the power, 2015-12-02 13:45:51]

Patchset 2 (id:??) landed as
https://crrev.com/88980864bcee9b92ad25beb4f3154b1b6e88acee
Cr-Commit-Position: refs/heads/master@{#362694}