Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1495443006: Keep WKWebView control group users in the control group (Closed)

Created:
5 years ago by stuartmorgan
Modified:
5 years ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep WKWebView control group users in the control group Don't require users who have entered the control group to be eligible for the trial in subsequent launches in order to stay in the control group. This makes the control group persistent for users who enter it (just as the experiment group is persistent for users who are migrated, although the mechanism there is very different) so there won't be different biasing around crashing or incognito use. Also fixes a recent regression that would cause force-enabled or force-disabled users not to report the group. TBR=rohitrao BUG=557115 TEST=For a control group user, either terminate in incognito, or crash. On the next launch, the user should still be in the control group. Committed: https://crrev.com/84a07f872099ccd12eda0b95ab45a0a099c2ffe1 Cr-Commit-Position: refs/heads/master@{#362992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M ios/chrome/browser/application_context_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 3 chunks +26 lines, -6 lines 0 comments Download
M ios/chrome/browser/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/pref_names.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
stuartmorgan
TBRing since it's a direct upstreaming.
5 years ago (2015-12-03 15:50:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495443006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495443006/1
5 years ago (2015-12-03 15:50:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 16:23:13 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-03 16:24:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84a07f872099ccd12eda0b95ab45a0a099c2ffe1
Cr-Commit-Position: refs/heads/master@{#362992}

Powered by Google App Engine
This is Rietveld 408576698