Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1495443003: Reland of [CQ] Update proto format to fix triggered builders. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1485813004/ ) Reason for revert: Should be fixed after https://codereview.chromium.org/1487413002/ Original issue's description: > Revert of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1486963002/ ) > > Reason for revert: > Maybe causing problems > > Original issue's description: > > [CQ] Update proto format to fix triggered builders. > > > > Depends on https://chromereviews.googleplex.com/319777013/ > > > > BUG=chromium:561530 > > LOG=n > > TBR=sergiyb@chromium.org, tandrii@chromium.org > > NOTRY=true > > > > Committed: https://crrev.com/51d6d619330080a76c5bc7a2ebdafebc6a808aa8 > > Cr-Commit-Position: refs/heads/master@{#32453} > > TBR=sergiyb@chromium.org,tandrii@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:561530 > > Committed: https://crrev.com/79ded5acc9da6a80cbd739c24c6dfa0cf207ae93 > Cr-Commit-Position: refs/heads/master@{#32464} TBR=sergiyb@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:561530 Committed: https://crrev.com/3cea13351c1af365013f51c7b67e72eeba79afe6 Cr-Commit-Position: refs/heads/master@{#32511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M infra/config/cq.cfg View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Reland of [CQ] Update proto format to fix triggered builders.
5 years ago (2015-12-02 12:53:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495443003/1
5 years ago (2015-12-02 12:54:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 12:55:07 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3cea13351c1af365013f51c7b67e72eeba79afe6 Cr-Commit-Position: refs/heads/master@{#32511}
5 years ago (2015-12-02 12:55:40 UTC) #6
Michael Achenbach
5 years ago (2015-12-02 13:26:58 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1493693003/ by machenbach@chromium.org.

The reason for reverting is: Still not working.

Powered by Google App Engine
This is Rietveld 408576698