Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149543004: Avoid deferencing a pointer before checking it. (Closed)

Created:
6 years, 10 months ago by etienneb
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chrisgao (Use stgao instead), frankf
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Avoid deferencing a pointer before checking it. This issue was found by a linter. R=frankf@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247830

Patch Set 1 #

Patch Set 2 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/test/chromedriver/chrome/zip_internal.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
etienneb
PTAL and CQ it.
6 years, 10 months ago (2014-01-29 18:33:24 UTC) #1
chrisgao (Use stgao instead)
lgtm Many thanks for the fix.
6 years, 10 months ago (2014-01-29 19:46:47 UTC) #2
stgao
lgtm Seems I used to wrong account... Do another lgtm.
6 years, 10 months ago (2014-01-29 19:48:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/149543004/20001
6 years, 10 months ago (2014-01-29 19:50:06 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 04:13:40 UTC) #5
Message was sent while issue was closed. 
Change committed as 247830

Powered by Google App Engine
This is Rietveld 408576698