Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 149543003: Unindented inclusion of +article fragment because it added extra whitespace to <pre> code blocks (Closed)

Created:
6 years, 10 months ago by pearlchen
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Unindented inclusion of +article fragment because it added extra whitespace to <pre> code blocks BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/common/extensions/docs/templates/private/article.html View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pearlchen
I noticed that multiline code blocks had bad formatting. It was due to extra tabs ...
6 years, 10 months ago (2014-01-29 16:11:19 UTC) #1
Renato Mangini (chromium)
lgtm
6 years, 10 months ago (2014-01-29 17:29:14 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-01-29 17:41:03 UTC) #3
not at google - send to devlin
lgtm
6 years, 10 months ago (2014-01-29 19:35:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pearlchen@chromium.org/149543003/1
6 years, 10 months ago (2014-01-29 19:57:50 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 08:41:42 UTC) #6
Message was sent while issue was closed.
Change committed as 247900

Powered by Google App Engine
This is Rietveld 408576698