Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: chrome/browser/chromeos/customization/customization_document_unittest.cc

Issue 1495403002: Observe adding external extensions via windows registry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync @tott Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/customization/customization_document_unittest.cc
diff --git a/chrome/browser/chromeos/customization/customization_document_unittest.cc b/chrome/browser/chromeos/customization/customization_document_unittest.cc
index a1d7356645653102590cb1d2d820bc5d14ed92ff..f6ccfeaa16a7afc7daf948c028e5a9536299df98 100644
--- a/chrome/browser/chromeos/customization/customization_document_unittest.cc
+++ b/chrome/browser/chromeos/customization/customization_document_unittest.cc
@@ -26,6 +26,7 @@
#include "components/syncable_prefs/pref_service_mock_factory.h"
#include "components/syncable_prefs/pref_service_syncable.h"
#include "content/public/test/test_browser_thread_bundle.h"
+#include "extensions/browser/external_install_info.h"
#include "extensions/common/extension.h"
#include "extensions/common/manifest.h"
#include "net/http/http_response_headers.h"
@@ -39,6 +40,8 @@ using ::testing::Exactly;
using ::testing::Invoke;
using ::testing::Mock;
using ::testing::_;
+using extensions::ExternalInstallInfoFile;
+using extensions::ExternalInstallInfoUpdateUrl;
namespace {
@@ -184,23 +187,17 @@ class MockExternalProviderVisitor
public:
MockExternalProviderVisitor() {}
- MOCK_METHOD7(OnExternalExtensionFileFound,
- bool(const std::string&,
- const base::Version*,
- const base::FilePath&,
- extensions::Manifest::Location,
- int,
- bool,
- bool));
- MOCK_METHOD6(OnExternalExtensionUpdateUrlFound,
- bool(const std::string&,
- const std::string&,
- const GURL&,
- extensions::Manifest::Location,
- int,
- bool));
+ MOCK_METHOD1(OnExternalExtensionFileFound,
+ bool(const ExternalInstallInfoFile&));
+ MOCK_METHOD2(OnExternalExtensionUpdateUrlFound,
+ bool(const ExternalInstallInfoUpdateUrl&, bool));
MOCK_METHOD1(OnExternalProviderReady,
void(const extensions::ExternalProviderInterface* provider));
+ MOCK_METHOD4(OnExternalProviderUpdateComplete,
+ void(const extensions::ExternalProviderInterface*,
+ const ScopedVector<ExternalInstallInfoUpdateUrl>&,
+ const ScopedVector<ExternalInstallInfoFile>&,
+ const std::set<std::string>& removed_extensions));
};
class ServicesCustomizationDocumentTest : public testing::Test {
@@ -362,12 +359,11 @@ TEST_F(ServicesCustomizationDocumentTest, NoCustomizationIdInVpd) {
extensions::Extension::FROM_WEBSTORE |
extensions::Extension::WAS_INSTALLED_BY_DEFAULT));
- EXPECT_CALL(visitor, OnExternalExtensionFileFound(_, _, _, _, _, _, _))
- .Times(0);
- EXPECT_CALL(visitor, OnExternalExtensionUpdateUrlFound(_, _, _, _, _, _))
- .Times(0);
+ EXPECT_CALL(visitor, OnExternalExtensionFileFound(_)).Times(0);
+ EXPECT_CALL(visitor, OnExternalExtensionUpdateUrlFound(_, _)).Times(0);
EXPECT_CALL(visitor, OnExternalProviderReady(_))
.Times(1);
+ EXPECT_CALL(visitor, OnExternalProviderUpdateComplete(_, _, _, _)).Times(0);
// Manually request a load.
RunUntilIdle();
@@ -407,23 +403,21 @@ TEST_F(ServicesCustomizationDocumentTest, DefaultApps) {
extensions::Extension::FROM_WEBSTORE |
extensions::Extension::WAS_INSTALLED_BY_DEFAULT));
- EXPECT_CALL(visitor, OnExternalExtensionFileFound(_, _, _, _, _, _, _))
- .Times(0);
- EXPECT_CALL(visitor, OnExternalExtensionUpdateUrlFound(_, _, _, _, _, _))
- .Times(0);
+ EXPECT_CALL(visitor, OnExternalExtensionFileFound(_)).Times(0);
+ EXPECT_CALL(visitor, OnExternalExtensionUpdateUrlFound(_, _)).Times(0);
EXPECT_CALL(visitor, OnExternalProviderReady(_))
.Times(1);
+ EXPECT_CALL(visitor, OnExternalProviderUpdateComplete(_, _, _, _)).Times(0);
// Manually request a load.
loader->StartLoading();
Mock::VerifyAndClearExpectations(&visitor);
- EXPECT_CALL(visitor, OnExternalExtensionFileFound(_, _, _, _, _, _, _))
- .Times(0);
- EXPECT_CALL(visitor, OnExternalExtensionUpdateUrlFound(_, _, _, _, _, _))
- .Times(2);
+ EXPECT_CALL(visitor, OnExternalExtensionFileFound(_)).Times(0);
+ EXPECT_CALL(visitor, OnExternalExtensionUpdateUrlFound(_, _)).Times(2);
EXPECT_CALL(visitor, OnExternalProviderReady(_))
.Times(1);
+ EXPECT_CALL(visitor, OnExternalProviderUpdateComplete(_, _, _, _)).Times(0);
RunUntilIdle();
EXPECT_TRUE(doc->IsReady());
@@ -457,23 +451,21 @@ TEST_F(ServicesCustomizationDocumentTest, CustomizationManifestNotFound) {
extensions::Extension::FROM_WEBSTORE |
extensions::Extension::WAS_INSTALLED_BY_DEFAULT));
- EXPECT_CALL(visitor, OnExternalExtensionFileFound(_, _, _, _, _, _, _))
- .Times(0);
- EXPECT_CALL(visitor, OnExternalExtensionUpdateUrlFound(_, _, _, _, _, _))
- .Times(0);
+ EXPECT_CALL(visitor, OnExternalExtensionFileFound(_)).Times(0);
+ EXPECT_CALL(visitor, OnExternalExtensionUpdateUrlFound(_, _)).Times(0);
EXPECT_CALL(visitor, OnExternalProviderReady(_))
.Times(1);
+ EXPECT_CALL(visitor, OnExternalProviderUpdateComplete(_, _, _, _)).Times(0);
// Manually request a load.
loader->StartLoading();
Mock::VerifyAndClearExpectations(&visitor);
- EXPECT_CALL(visitor, OnExternalExtensionFileFound(_, _, _, _, _, _, _))
- .Times(0);
- EXPECT_CALL(visitor, OnExternalExtensionUpdateUrlFound(_, _, _, _, _, _))
- .Times(0);
+ EXPECT_CALL(visitor, OnExternalExtensionFileFound(_)).Times(0);
+ EXPECT_CALL(visitor, OnExternalExtensionUpdateUrlFound(_, _)).Times(0);
EXPECT_CALL(visitor, OnExternalProviderReady(_))
.Times(1);
+ EXPECT_CALL(visitor, OnExternalProviderUpdateComplete(_, _, _, _)).Times(0);
RunUntilIdle();
EXPECT_TRUE(doc->IsReady());
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698