Disable noisy printf in drive_integration_service.cc

Disable noisy printf in drive_integration_service.cc

This is printed in every browser test, and just adds noise. Switch it
to LOG_IF so it's only printed when needed.

R=kinaba@chromium.org
BUG=339891
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248871

[kinaba, 2014-01-31 23:07:37]

lgtm for now, for clean test run.

However, it's unexpected that the code path is hit everytime. +hashimoto: we
need to look into it.

[hashimoto, 2014-02-03 04:28:18]

This line is shown because ResourceMetadataStorage clears
|cache_file_scan_is_needed| only when usable DB is found on the disk. (i.e.
false positive WARNING on the first run and all tests)
Sorry for the mess.

https://codereview.chromium.org/149533005/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/drive_integration_service.cc (right):

https://codereview.chromium.org/149533005/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/drive_integration_service.cc:154: VLOG(1) << "DB
could not be opened for some reasons. "
Could you change this to LOG_IF(WARNING, !recovered_cache_info.empty())?
This should suppress the output for testing.

[danakj, 2014-02-03 16:57:28]

Thanks, PTAL

https://codereview.chromium.org/149533005/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/drive_integration_service.cc (right):

https://codereview.chromium.org/149533005/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/drive_integration_service.cc:154: VLOG(1) << "DB
could not be opened for some reasons. "
On 2014/02/03 04:28:18, hashimoto wrote:
> Could you change this to LOG_IF(WARNING, !recovered_cache_info.empty())?
> This should suppress the output for testing.

Yup that works.

[hashimoto, 2014-02-04 01:43:38]

lgtm

[danakj, 2014-02-04 18:25:15]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-02-04 18:25:19]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-02-04 18:25:44]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-02-04 18:29:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/149533005/70001

[commit-bot: I haz the power, 2014-02-04 20:23:56]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-02-04 20:25:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/149533005/70001

[commit-bot: I haz the power, 2014-02-05 00:50:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/149533005/70001

[commit-bot: I haz the power, 2014-02-05 06:14:52]

Change committed as 248871