Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1495323002: Fix unit_tests crash on start-up for GN Android (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
CC:
David Trainor- moved to gerrit
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unit_tests crash on start-up for GN Android TBR=brettw BUG=566111 Committed: https://crrev.com/14d1b99388647b719bc02be6f282b989d6ee19d5 Cr-Commit-Position: refs/heads/master@{#363280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
agrieve
Should fix Android GN bot failure.
5 years ago (2015-12-04 18:50:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495323002/1
5 years ago (2015-12-04 18:57:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 20:11:32 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/14d1b99388647b719bc02be6f282b989d6ee19d5 Cr-Commit-Position: refs/heads/master@{#363280}
5 years ago (2015-12-04 20:12:44 UTC) #10
brettw
5 years ago (2015-12-04 20:18:33 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698