Allow return of Future in async function

Allow return of Future in async function.

Fixes dart-lang/dev_compiler#316
Fixes #24540
Fixes flutter/flutter#607
Fixes #25042

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/7f43d10eeb509c5141961d142ea705bc4d94103e

[Leaf, 2015-12-04 23:21:02]

Description was changed from

==========
Allow return of Future in async function

BUG=
==========

to

==========
Allow return of Future in async function.

Fixes dart-lang/dev_compiler#316
Fixes #24540
Fixes flutter/flutter#607
Fixes #25042

BUG=
==========

[Leaf, 2015-12-04 23:21:02]

leafp@google.com changed reviewers:
+ vsm@google.com

[vsm, 2015-12-04 23:25:55]

lgtm

https://codereview.chromium.org/1495263003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/1495263003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:2368: Future<int> foo4()
async => (/*severe:StaticTypeError*/new
Future<String>.value(/*info:DynamicCast*/x));
May want to rename one of the 'foo4' methods - we don't report non-strong
analyzer errors - so it may mask something.

https://codereview.chromium.org/1495263003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:2374: Future<int> bar4()
async { return (/*severe:StaticTypeError*/new
Future<String>.value(/*info:DynamicCast*/x)); }
Ditto

[Leaf, 2015-12-04 23:30:03]

good catch, thanks.

https://codereview.chromium.org/1495263003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/1495263003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:2368: Future<int> foo4()
async => (/*severe:StaticTypeError*/new
Future<String>.value(/*info:DynamicCast*/x));
On 2015/12/04 23:25:54, vsm wrote:
> May want to rename one of the 'foo4' methods - we don't report non-strong
> analyzer errors - so it may mask something.

Done.

https://codereview.chromium.org/1495263003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:2374: Future<int> bar4()
async { return (/*severe:StaticTypeError*/new
Future<String>.value(/*info:DynamicCast*/x)); }
On 2015/12/04 23:25:54, vsm wrote:
> Ditto

Done.

[Leaf, 2015-12-04 23:33:32]

Description was changed from

==========
Allow return of Future in async function.

Fixes dart-lang/dev_compiler#316
Fixes #24540
Fixes flutter/flutter#607
Fixes #25042

BUG=
==========

to

==========
Allow return of Future in async function.

Fixes dart-lang/dev_compiler#316
Fixes #24540
Fixes flutter/flutter#607
Fixes #25042

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7f43d10eeb509c5141961d142ea705bc4d94103e
==========

[Leaf, 2015-12-04 23:33:33]

Committed patchset #2 (id:20001) manually as
7f43d10eeb509c5141961d142ea705bc4d94103e (presubmit successful).