Issue 1495263002: QuicPacketCreator knows when to start FEC protection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1495263002: QuicPacketCreator knows when to start FEC protection. (Closed)

Created:
5 years ago by Jo Kulik

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@108738647

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

QuicPacketCreator knows when to start FEC protection. QuicPacketCreator: Call MaybeStartFecProtection in ConsumeData. Move MaybeStartFecProtection from public to private. Merge internal change: 108743696 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+159 lines, -123 lines)			Patch
M	net/quic/quic_packet_creator.h	View	5 chunks	+20 lines, -14 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	28 chunks	+128 lines, -97 lines	0 comments	Download
M	net/quic/quic_packet_generator.cc	View	4 chunks	+3 lines, -8 lines	0 comments	Download

Depends on Patchset:

Issue 1495243002 Patch 1

Dependent Patchsets:

Issue 1497863005 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages