Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: net/quic/quic_protocol.h

Issue 1495243002: Remove EncryptionLevel from QUIC's RetransmittableFrames and add it to TransmissionInfo. No functi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@108735153
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_packet_generator.cc ('k') | net/quic/quic_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_protocol.h
diff --git a/net/quic/quic_protocol.h b/net/quic/quic_protocol.h
index c614cc414f026d88f437a1f491f8a2d35028dbbe..9d163a6afe2b2b4deafec316ce02901f4bd595f7 100644
--- a/net/quic/quic_protocol.h
+++ b/net/quic/quic_protocol.h
@@ -1134,7 +1134,7 @@ class NET_EXPORT_PRIVATE QuicEncryptedPacket : public QuicData {
class NET_EXPORT_PRIVATE RetransmittableFrames {
public:
- explicit RetransmittableFrames(EncryptionLevel level);
+ RetransmittableFrames();
~RetransmittableFrames();
// Takes ownership of the frame inside |frame|.
@@ -1150,17 +1150,12 @@ class NET_EXPORT_PRIVATE RetransmittableFrames {
return has_crypto_handshake_;
}
- EncryptionLevel encryption_level() const {
- return encryption_level_;
- }
-
bool needs_padding() const { return needs_padding_; }
void set_needs_padding(bool needs_padding) { needs_padding_ = needs_padding; }
private:
QuicFrames frames_;
- const EncryptionLevel encryption_level_;
IsHandshake has_crypto_handshake_;
bool needs_padding_;
// Data referenced by the StringPiece of a QuicStreamFrame.
@@ -1223,6 +1218,7 @@ struct NET_EXPORT_PRIVATE TransmissionInfo {
// Constructs a Transmission with a new all_tranmissions set
// containing |packet_number|.
TransmissionInfo(RetransmittableFrames* retransmittable_frames,
+ EncryptionLevel level,
QuicPacketNumberLength packet_number_length,
TransmissionType transmission_type,
QuicTime sent_time,
@@ -1232,6 +1228,7 @@ struct NET_EXPORT_PRIVATE TransmissionInfo {
~TransmissionInfo();
RetransmittableFrames* retransmittable_frames;
+ EncryptionLevel encryption_level;
QuicPacketNumberLength packet_number_length;
QuicPacketLength bytes_sent;
uint16 nack_count;
« no previous file with comments | « net/quic/quic_packet_generator.cc ('k') | net/quic/quic_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698