Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: net/quic/quic_packet_creator_test.cc

Issue 1495243002: Remove EncryptionLevel from QUIC's RetransmittableFrames and add it to TransmissionInfo. No functi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@108735153
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_packet_creator.cc ('k') | net/quic/quic_packet_generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_creator_test.cc
diff --git a/net/quic/quic_packet_creator_test.cc b/net/quic/quic_packet_creator_test.cc
index 1fd652fa44b4cc64c88bba8279563a05aba7c9de..a39784275b98adceef1e5244ab7f040c30ebcce0 100644
--- a/net/quic/quic_packet_creator_test.cc
+++ b/net/quic/quic_packet_creator_test.cc
@@ -539,11 +539,12 @@ TEST_P(QuicPacketCreatorTest, ReserializeFramesWithSequenceNumberLength) {
PACKET_2BYTE_PACKET_NUMBER);
QuicStreamFrame* stream_frame =
new QuicStreamFrame(kCryptoStreamId, /*fin=*/false, 0u, StringPiece());
- RetransmittableFrames frames(ENCRYPTION_NONE);
+ RetransmittableFrames frames;
frames.AddFrame(QuicFrame(stream_frame));
char buffer[kMaxPacketSize];
SerializedPacket serialized = creator_.ReserializeAllFrames(
- frames, PACKET_1BYTE_PACKET_NUMBER, buffer, kMaxPacketSize);
+ frames, ENCRYPTION_NONE, PACKET_1BYTE_PACKET_NUMBER, buffer,
+ kMaxPacketSize);
EXPECT_EQ(PACKET_4BYTE_PACKET_NUMBER,
QuicPacketCreatorPeer::NextPacketNumberLength(&creator_));
EXPECT_EQ(PACKET_2BYTE_PACKET_NUMBER,
@@ -569,14 +570,14 @@ TEST_P(QuicPacketCreatorTest, ReserializeFramesWithPadding) {
QuicIOVector io_vector(MakeIOVector("fake handshake message data"));
UniqueStreamBuffer stream_buffer;
QuicPacketCreatorPeer::CreateStreamFrame(&creator_, kCryptoStreamId,
- io_vector, 0u, 0u, false, &frame,
- &stream_buffer);
- RetransmittableFrames frames(ENCRYPTION_NONE);
+ io_vector, 0u, 0u, false, &frame);
+ RetransmittableFrames frames;
frames.AddFrame(frame);
frames.set_needs_padding(true);
char buffer[kMaxPacketSize];
SerializedPacket serialized = creator_.ReserializeAllFrames(
- frames, QuicPacketCreatorPeer::NextPacketNumberLength(&creator_), buffer,
+ frames, ENCRYPTION_NONE,
+ QuicPacketCreatorPeer::NextPacketNumberLength(&creator_), buffer,
kMaxPacketSize);
EXPECT_EQ(kDefaultMaxPacketSize, serialized.packet->length());
delete serialized.packet;
@@ -593,16 +594,16 @@ TEST_P(QuicPacketCreatorTest, ReserializeFramesWithFullPacketAndPadding) {
QuicFrame frame;
QuicIOVector io_vector(MakeIOVector(data));
UniqueStreamBuffer stream_buffer;
- QuicPacketCreatorPeer::CreateStreamFrame(&creator_, kCryptoStreamId,
- io_vector, 0, kOffset, false,
- &frame, &stream_buffer);
- RetransmittableFrames frames(ENCRYPTION_NONE);
+ QuicPacketCreatorPeer::CreateStreamFrame(
+ &creator_, kCryptoStreamId, io_vector, 0, kOffset, false, &frame);
+ RetransmittableFrames frames;
frames.AddFrame(frame);
frames.set_needs_padding(true);
char buffer[kMaxPacketSize];
SerializedPacket serialized = creator_.ReserializeAllFrames(
- frames, QuicPacketCreatorPeer::NextPacketNumberLength(&creator_),
- buffer, kMaxPacketSize);
+ frames, ENCRYPTION_NONE,
+ QuicPacketCreatorPeer::NextPacketNumberLength(&creator_), buffer,
+ kMaxPacketSize);
// If there is not enough space in the packet to fit a padding frame
// (1 byte) and to expand the stream frame (another 2 bytes) the packet
@@ -795,8 +796,7 @@ TEST_P(QuicPacketCreatorTest, StreamFrameConsumption) {
QuicIOVector io_vector(MakeIOVector(data));
UniqueStreamBuffer stream_buffer;
size_t bytes_consumed = QuicPacketCreatorPeer::CreateStreamFrame(
- &creator_, kClientDataStreamId1, io_vector, 0u, kOffset, false, &frame,
- &stream_buffer);
+ &creator_, kClientDataStreamId1, io_vector, 0u, kOffset, false, &frame);
EXPECT_EQ(capacity - bytes_free, bytes_consumed);
ASSERT_TRUE(creator_.AddSavedFrame(frame));
@@ -829,8 +829,7 @@ TEST_P(QuicPacketCreatorTest, StreamFrameConsumptionWithFec) {
QuicIOVector io_vector(MakeIOVector(data));
UniqueStreamBuffer stream_buffer;
size_t bytes_consumed = QuicPacketCreatorPeer::CreateStreamFrame(
- &creator_, kClientDataStreamId1, io_vector, 0u, kOffset, false, &frame,
- &stream_buffer);
+ &creator_, kClientDataStreamId1, io_vector, 0u, kOffset, false, &frame);
EXPECT_EQ(capacity - bytes_free, bytes_consumed);
ASSERT_TRUE(creator_.AddSavedFrame(frame));
« no previous file with comments | « net/quic/quic_packet_creator.cc ('k') | net/quic/quic_packet_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698