Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 149513014: Docserver: Add FileSystem.Exists method and start sanity checking path format (Closed)

Created:
6 years, 10 months ago by not at google - send to devlin
Modified:
6 years, 10 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Docserver: Add FileSystem.Exists method and start sanity checking path format via a new path_utils utility. BUG=none R=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248730

Patch Set 1 #

Total comments: 10

Patch Set 2 : yoz #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -24 lines) Patch
chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
chrome/common/extensions/docs/server2/appengine_url_fetcher.py View 2 chunks +2 lines, -2 lines 0 comments Download
chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download
chrome/common/extensions/docs/server2/file_system.py View 1 3 chunks +35 lines, -6 lines 0 comments Download
chrome/common/extensions/docs/server2/file_system_test.py View 3 chunks +43 lines, -12 lines 0 comments Download
chrome/common/extensions/docs/server2/path_util.py View 1 chunk +36 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/path_util_test.py View 1 chunk +29 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/render_servlet.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
6 years, 10 months ago (2014-01-31 22:21:00 UTC) #1
Yoyo Zhou
LGTM, nits https://chromiumcodereview.appspot.com/149513014/diff/1/chrome/common/extensions/docs/server2/file_system.py File chrome/common/extensions/docs/server2/file_system.py (right): https://chromiumcodereview.appspot.com/149513014/diff/1/chrome/common/extensions/docs/server2/file_system.py#newcode85 chrome/common/extensions/docs/server2/file_system.py:85: False is not. This method will not ...
6 years, 10 months ago (2014-02-04 00:27:19 UTC) #2
Yoyo Zhou
Oops, reading the next patch: https://chromiumcodereview.appspot.com/149513014/diff/1/chrome/common/extensions/docs/server2/file_system.py File chrome/common/extensions/docs/server2/file_system.py (right): https://chromiumcodereview.appspot.com/149513014/diff/1/chrome/common/extensions/docs/server2/file_system.py#newcode134 chrome/common/extensions/docs/server2/file_system.py:134: (base, files, dirs) recursively, ...
6 years, 10 months ago (2014-02-04 00:30:03 UTC) #3
not at google - send to devlin
https://codereview.chromium.org/149513014/diff/1/chrome/common/extensions/docs/server2/file_system.py File chrome/common/extensions/docs/server2/file_system.py (right): https://codereview.chromium.org/149513014/diff/1/chrome/common/extensions/docs/server2/file_system.py#newcode85 chrome/common/extensions/docs/server2/file_system.py:85: False is not. This method will not throw a ...
6 years, 10 months ago (2014-02-04 16:14:40 UTC) #4
not at google - send to devlin
6 years, 10 months ago (2014-02-04 16:24:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r248730.

Powered by Google App Engine
This is Rietveld 408576698