Source/core/inspector/InspectorStyleSheet.cpp - Issue 149513011: Pass around CSSSelector by reference instead of pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorStyleSheet.cpp

Issue 149513011: Pass around CSSSelector by reference instead of pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorStyleSheet.cpp

diff --git a/Source/core/inspector/InspectorStyleSheet.cpp b/Source/core/inspector/InspectorStyleSheet.cpp

index a19ac5e7dd2d5fc45d6d2fee15caeb6a163be801..7501b169009e535ed996efbd4362af633b601853 100644

--- a/Source/core/inspector/InspectorStyleSheet.cpp

+++ b/Source/core/inspector/InspectorStyleSheet.cpp

@@ -1247,7 +1247,7 @@ PassRefPtr<TypeBuilder::CSS::SelectorList> InspectorStyleSheet::buildObjectForSe

else {

selectors = TypeBuilder::Array<TypeBuilder::CSS::Selector>::create();

const CSSSelectorList& selectorList = rule->styleRule()->selectorList();

- for (const CSSSelector* selector = selectorList.first(); selector; selector = CSSSelectorList::next(selector))

+ for (const CSSSelector* selector = selectorList.first(); selector; selector = CSSSelectorList::next(*selector))

selectors->addItem(TypeBuilder::CSS::Selector::create().setValue(selector->selectorText()).release());

}

RefPtr<TypeBuilder::CSS::SelectorList> result = TypeBuilder::CSS::SelectorList::create()

« no previous file with comments | « Source/core/inspector/InspectorCSSAgent.cpp ('k') | Source/web/WebSelector.cpp » ('j') | no next file with comments »