Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: webkit/glue/webframeloaderclient_impl.cc

Issue 149510: Correct bad WebKit merge.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webframeloaderclient_impl.cc
===================================================================
--- webkit/glue/webframeloaderclient_impl.cc (revision 20246)
+++ webkit/glue/webframeloaderclient_impl.cc (working copy)
@@ -241,6 +241,16 @@
request.setTargetType(DetermineTargetTypeFromLoader(loader));
}
+ // Inherit the first party for cookies from the request's frame. However, if
+ // the request is for a main frame, the current document's
+ // firstPartyForCookies is the old document, so we leave firstPartyForCookies
+ // empty to indicate that the request is a first-party request.
+ if (request.targetType() != ResourceRequest::TargetIsMainFrame &&
darin (slow to review) 2009/07/12 03:45:40 Shouldn't this kind of logic live in WebCore? Or,
abarth-chromium 2009/07/12 08:10:51 This patch is just added back some code I accident
darin (slow to review) 2009/07/12 13:05:04 OK,LGTM
+ webframe_->frame()->document()) {
+ request.setFirstPartyForCookies(
+ webframe_->frame()->document()->firstPartyForCookies());
+ }
+
// FrameLoader::loadEmptyDocumentSynchronously() creates an empty document
// with no URL. We don't like that, so we'll rename it to about:blank.
if (request.url().isEmpty())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698