GTK: For the render view, count keyboard grab shadows the same as focus event...

GTK: For the render view, count keyboard grab shadows the same as focus events.

This fixes an age old bug that dropdown menus still looked depressed after you select something from them and they collapse. It also fixes the more recent bug that you could have focus in the render view without any indication drawn by the renderer. I suspect there was a change to webkit that exacerbated this bug, because it seems like something we would have noticed earlier.

Verified in a debugger that showing/hiding a dropdown menu doesn't emit focus signals, but does emit grab notify signals. Also verified that the bug is no longer reproducible in a simple page with <select> and <input> elements.

BUG=16313
TEST=see desc.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20574

[Evan Stade, 2009-07-11 01:14:06]

http://codereview.chromium.org/149506/diff/1/2
File chrome/browser/renderer_host/render_widget_host_view_gtk.cc (right):

http://codereview.chromium.org/149506/diff/1/2#newcode223
Line 223: if (was_grabbed)
this check seems backward, but is not

[tony, 2009-07-13 17:34:55]

LGTM