Issue 1495033003: Reposition the settings button as part of the notification update method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1495033003: Reposition the settings button as part of the notification update method (Closed)

Created:
5 years ago by Miguel Garcia

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

Reposition the settings button as part of the notification update method BUG=564028 Review URL: https://codereview.chromium.org/1487373003 Cr-Commit-Position: refs/heads/master@{#362749} (cherry picked from commit 5964baec90ea4aec2683bc00c732a891b8411179) Committed: https://chromium.googlesource.com/chromium/src/+/13648fd22af33f58b0602aae4cecb4868ceffe6c

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	ui/message_center/cocoa/notification_controller.mm	View		3 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Miguel Garcia

5 years ago (2015-12-04 11:12:32 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
13648fd22af33f58b0602aae4cecb4868ceffe6c.