third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent.html - Issue 1495033002: Clear intruding floats when moving child to inline parent.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent.html

Issue 1495033002: Clear intruding floats when moving child to inline parent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@558405-5

Patch Set: Updated Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/block/float/clear-intruding-floats-when-moving-to-inline-parent-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/js-test.js"></script>
	mstensho (USE GERRIT) 2015/12/07 21:14:44 I asked in my previous batch of comments, but got I asked in my previous batch of comments, but got no response: Would it be possible to come up with an additional, super-simple test, if we add the right assertions to the right places? :) It would be a useful addition, to more clearly explain what we're trying to fix here. rhogan 2015/12/08 18:15:44 OK. Done! Show quoted text On 2015/12/07 at 21:14:44, mstensho wrote: > I asked in my previous batch of comments, but got no response: > > Would it be possible to come up with an additional, super-simple test, if we add the right assertions to the right places? :) It would be a useful addition, to more clearly explain what we're trying to fix here. OK. Done!
	3 <div></div>

	4 <span></span>

	5 <div id="killMe" style="float:right; width:100px; height:100px;"></div>

	6 <div id="container">

	7 <canvas id="canvas" style="display:block;"></canvas>

	8 </div>

	9 <script>

	10 // Trigger layout.

	11 document.body.offsetTop;

	12

	13 // Delete the float.

	14 document.getElementById("killMe").style.display = "none";

	15

	16 // Take it out of normal flow and establish a new block formatting

	17 // context, so that the preceding float (which no longer exists, by

	18 // the way) can no longer intrude. Not being in normal flow anymore

	19 // also means that it can be moved into an adjacent anonymous block if

	20 // one exists.

	21 document.getElementById("container").style.position = 'absolute';

	22

	23 // Trigger style recalculation, but NOT layout.

	24 getComputedStyle(document.getElementById("container")).color;

	25

	26 // When zoom changes, LayoutReplaced::styleDidChange() will call

	27 // intrinsicSizeChanged(), which will do an out-of-course layout on the canv as element.

	28 document.getElementById("canvas").style.zoom = 0.50;

	29 testPassed("crbug.com/562208: Clear intruding floats when moving child to in line parent. Passes if it doesn't crash.");

	30 </script>

OLD	NEW