Fuzzy password matching kill switch by Finch

Fuzzy password matching kill switch by Finch

This is the client side part, the server config is in CL 61376672.

BUG=338260, 338289
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251038

[vabr (Chromium), 2014-02-11 14:36:07]

Hi Garrett,

Could you please review?

Thanks,
Vaclav

[Garrett Casto, 2014-02-12 20:06:19]

LGTM with nits.

https://codereview.chromium.org/149503006/diff/1/components/password_manager/...
File components/password_manager/core/browser/psl_matching_helper.cc (right):

https://codereview.chromium.org/149503006/diff/1/components/password_manager/...
components/password_manager/core/browser/psl_matching_helper.cc:20: const char
kPSLMatchingDesktopStudyName[] = "PSLMatchingDesktop";
I'm not sure "study" is the right name here. I would use "experiment" instead.

[vabr (Chromium), 2014-02-13 08:23:30]

Thanks, Garrett.

Comment addressed, sending to CQ.

Cheers,
Vaclav

https://codereview.chromium.org/149503006/diff/1/components/password_manager/...
File components/password_manager/core/browser/psl_matching_helper.cc (right):

https://codereview.chromium.org/149503006/diff/1/components/password_manager/...
components/password_manager/core/browser/psl_matching_helper.cc:20: const char
kPSLMatchingDesktopStudyName[] = "PSLMatchingDesktop";
On 2014/02/12 20:06:19, Garrett Casto wrote:
> I'm not sure "study" is the right name here. I would use "experiment" instead.

I checked the callsites of FieldTrialList::FindFullName across the codebase, and
saw things like "Study", "FieldTrial", "Trial". I did not see "Experiment", so
as a safe bet I'll rename the variable here to FieldTrial (that's what it is,
after all).

I don't think it matter too much, and I'm happy to quickly upload a renaming CL
if you really want "Experiment".

[vabr (Chromium), 2014-02-13 08:38:54]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2014-02-13 08:39:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/149503006/210001

[commit-bot: I haz the power, 2014-02-13 09:26:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 09:26:06]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[vabr (Chromium), 2014-02-13 10:46:03]

The use of the new variables was gated by !OS_ANDROID and !OS_IOS defines, but
the definition was not. Fixing now in patch set 3. This does not change anything
in how the code works, so I'll continue landing it.

Cheers,
Vaclav

[vabr (Chromium), 2014-02-13 10:46:21]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2014-02-13 10:47:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/149503006/420002

[commit-bot: I haz the power, 2014-02-13 16:00:24]

Change committed as 251038