third_party/WebKit/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied.html - Issue 1495013002: Check for equality of the URL's origin in replaceState/pushState

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied.html

Issue 1495013002: Check for equality of the URL's origin in replaceState/pushState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Allow --disable-web-security again, add more tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/loading/state-object-security-exception-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/navigation/pushstate-whitelisted-in-blob-denied.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <meta http-equiv="Content-Security-Policy" content="sandbox allow-scripts">

	2 <script>
	Mike West 2015/12/08 13:45:18 Please write new tests with `testharness.js` (and Please write new tests with `testharness.js` (and consider upstreaming the non-Chrome-specific bits to https://github.com/w3c/web-platform-tests/tree/master/html/browsers/history/t... if the tests there aren't sufficient). robwu 2015/12/08 14:06:39 I believe that the test is not suited for the test Show quoted text On 2015/12/08 13:45:18, Mike West wrote: > Please write new tests with `testharness.js` (and consider upstreaming the > non-Chrome-specific bits to > https://github.com/w3c/web-platform-tests/tree/master/html/browsers/history/t... > if the tests there aren't sufficient). I believe that the test is not suited for the test harness, because the imported tests run at file:// with universal access. This is also the reason why this expectation failed: https://chromium.googlesource.com/chromium/src/+/1eb37c3ac47c16d2b463879a2402... Mike West 2015/12/08 14:18:41 That's a bug in the way that we're running those t Show quoted text On 2015/12/08 at 14:06:39, robwu wrote: > I believe that the test is not suited for the test harness, because the imported tests run at file:// with universal access. This is also the reason why this expectation failed: https://chromium.googlesource.com/chromium/src/+/1eb37c3ac47c16d2b463879a2402... That's a bug in the way that we're running those tests. We ought to be running them through `wptserve`, but that isn't wired up to the test runner yet. If you execute the tests from http://w3c-test.org/tools/runner/index.html, you'll see more reasonable results. There's value to the ecosystem in upstreaming these tests, even if we're doing a bad job as a project at running them in an automated fashion.
	3 if (window.testRunner) {

	4 testRunner.dumpAsText();

	5 }

	6 try {

	7 history.pushState(null, null, document.URL);

	8 document.write("FAIL URL at unique origin was manipulated via pushState.");

	9 } catch(e) {

	10 document.write("PASS: unique URLs cannot be manipulated via pushState.");

	11 }

	12 </script>

OLD	NEW