Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 14950002: Add enable*Features functions in preparation for using them in content. (Closed)

Created:
7 years, 7 months ago by eseidel
Modified:
7 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, jamesr, abarth_chromum.org, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Add enable*Features functions in preparation for using them in content. I've manually verified that these are the exact set of flags that RenderThreadImpl::InitializeWebKit() sets. Once this lands and rolls into chromium, I will change RenderThreadImpl to use these functions and then we can autogenerate this list from RuntimeEnabledFeatures.in instead of having it hard-coded. Note that these lists do not take ports into account, that's currently still a content-layer concern. Eventually perhaps we should make RuntimeEnabledFeatures aware of how "stable" on android may be different from "stable" on other platforms but for now I've left that in content. BUG=237740 R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149671

Patch Set 1 #

Patch Set 2 : Added FIXMEs about using the bool arguments after the x-repo dance is done. #

Patch Set 3 : Used the wrong macro for UNUSED, fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M Source/WebKit/chromium/public/WebRuntimeFeatures.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 2 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eseidel
7 years, 7 months ago (2013-05-03 22:02:41 UTC) #1
Dirk Pranke
lgtm
7 years, 7 months ago (2013-05-03 22:24:00 UTC) #2
eseidel
Now I just need to get jamesr, tkent, abarth, darin, or dglazkov to approve the ...
7 years, 7 months ago (2013-05-03 22:31:50 UTC) #3
dglazkov
LGTM
7 years, 7 months ago (2013-05-03 23:48:01 UTC) #4
eseidel
7 years, 7 months ago (2013-05-03 23:55:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r149671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698