More media::PipelineImpl cleanup, this time focusing on not taking down the render process.

media/base/pipeline_impl_unittest.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/waitable_event.h"
 #include "media/base/pipeline_impl.h"
 #include "media/base/media_format.h"
 #include "media/base/filters.h"
 #include "media/base/factory.h"
 #include "media/base/filter_host.h"
 #include "media/base/mock_filters.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::DoAll;
 using ::testing::Mock;
 using ::testing::Return;
 using ::testing::StrictMock;
 
 namespace media {
 
 // Used for setting expectations on pipeline callbacks.  Using a StrictMock
 // also lets us test for missing callbacks.
 class CallbackHelper {
  public:
   CallbackHelper() {}
   virtual ~CallbackHelper() {}
 
-  MOCK_METHOD1(OnInitialize, void(bool result));
+  MOCK_METHOD1(OnStart, void(bool result));
   MOCK_METHOD1(OnSeek, void(bool result));
   MOCK_METHOD1(OnStop, void(bool result));
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CallbackHelper);
 };
 
 // TODO(scherkus): even though some filters are initialized on separate
 // threads these test aren't flaky... why?  It's because filters' Initialize()
 // is executed on |message_loop_| and the mock filters instantly call
@@ skipping 18 matching lines @@
                                &CallbackHelper::OnStop));
     message_loop_.RunAllPending();
   }
 
  protected:
   // Sets up expectations to allow the data source to initialize.
   void InitializeDataSource() {
     EXPECT_CALL(*mocks_->data_source(), Initialize(""))
         .WillOnce(DoAll(InitializationComplete(mocks_->data_source()),
                         Return(true)));
+    EXPECT_CALL(*mocks_->data_source(), SetPlaybackRate(0.0f));
     EXPECT_CALL(*mocks_->data_source(), Stop());
   }
 
   // Sets up expectations to allow the demuxer to initialize.
   typedef std::vector<MockDemuxerStream*> MockDemuxerStreamVector;
   void InitializeDemuxer(MockDemuxerStreamVector* streams) {
     EXPECT_CALL(*mocks_->demuxer(), Initialize(mocks_->data_source()))
         .WillOnce(DoAll(InitializationComplete(mocks_->demuxer()),
                         Return(true)));
     EXPECT_CALL(*mocks_->demuxer(), GetNumberOfStreams())
         .WillRepeatedly(Return(streams->size()));
+    EXPECT_CALL(*mocks_->demuxer(), SetPlaybackRate(0.0f));
     EXPECT_CALL(*mocks_->demuxer(), Stop());
 
     // Configure the demuxer to return the streams.
     for (size_t i = 0; i < streams->size(); ++i) {
       scoped_refptr<DemuxerStream> stream = (*streams)[i];
       EXPECT_CALL(*mocks_->demuxer(), GetStream(i))
           .WillRepeatedly(Return(stream));
     }
   }
 
   // Sets up expectations to allow the video decoder to initialize.
   void InitializeVideoDecoder(MockDemuxerStream* stream) {
     EXPECT_CALL(*mocks_->video_decoder(), Initialize(stream))
         .WillOnce(DoAll(InitializationComplete(mocks_->video_decoder()),
                         Return(true)));
+    EXPECT_CALL(*mocks_->video_decoder(), SetPlaybackRate(0.0f));
     EXPECT_CALL(*mocks_->video_decoder(), Stop());
   }
 
   // Sets up expectations to allow the audio decoder to initialize.
   void InitializeAudioDecoder(MockDemuxerStream* stream) {
     EXPECT_CALL(*mocks_->audio_decoder(), Initialize(stream))
         .WillOnce(DoAll(InitializationComplete(mocks_->audio_decoder()),
                         Return(true)));
+    EXPECT_CALL(*mocks_->audio_decoder(), SetPlaybackRate(0.0f));
     EXPECT_CALL(*mocks_->audio_decoder(), Stop());
   }
 
   // Sets up expectations to allow the video renderer to initialize.
   void InitializeVideoRenderer() {
     EXPECT_CALL(*mocks_->video_renderer(), Initialize(mocks_->video_decoder()))
         .WillOnce(DoAll(InitializationComplete(mocks_->video_renderer()),
                         Return(true)));
+    EXPECT_CALL(*mocks_->video_renderer(), SetPlaybackRate(0.0f));
     EXPECT_CALL(*mocks_->video_renderer(), Stop());
   }
 
   // Sets up expectations to allow the audio renderer to initialize.
   void InitializeAudioRenderer() {
     EXPECT_CALL(*mocks_->audio_renderer(), Initialize(mocks_->audio_decoder()))
         .WillOnce(DoAll(InitializationComplete(mocks_->audio_renderer()),
                         Return(true)));
+    EXPECT_CALL(*mocks_->audio_renderer(), SetPlaybackRate(0.0f));
+    EXPECT_CALL(*mocks_->audio_renderer(), SetVolume(0.0f));
     EXPECT_CALL(*mocks_->audio_renderer(), Stop());
   }
 
   // Sets up expectations on the callback and initializes the pipeline.  Called
   // afters tests have set expectations any filters they wish to use.
   void InitializePipeline(bool callback_result) {
     // Expect an initialization callback.
-    EXPECT_CALL(callbacks_, OnInitialize(callback_result));
+    EXPECT_CALL(callbacks_, OnStart(callback_result));
     pipeline_.Start(mocks_, "",
                     NewCallback(reinterpret_cast<CallbackHelper*>(&callbacks_),
-                                &CallbackHelper::OnInitialize));
+                                &CallbackHelper::OnStart));
     message_loop_.RunAllPending();
   }
 
   // Fixture members.
   StrictMock<CallbackHelper> callbacks_;
   MessageLoop message_loop_;
   PipelineImpl pipeline_;
   scoped_refptr<media::MockFilterFactory> mocks_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PipelineImplTest);
 };
 
+// Test that playback controls methods no-op when the pipeline hasn't been
+// started.
+TEST_F(PipelineImplTest, NotStarted) {
+  const base::TimeDelta kZero;
+
+  // StrictMock<> will ensure these never get called, and valgrind/purify will
+  // make sure the callbacks are instantly deleted.
+  pipeline_.Start(NULL, "",
+                  NewCallback(reinterpret_cast<CallbackHelper*>(&callbacks_),
+                              &CallbackHelper::OnStart));
+  pipeline_.Stop(NewCallback(reinterpret_cast<CallbackHelper*>(&callbacks_),
+                             &CallbackHelper::OnStop));
+  pipeline_.Seek(kZero,
+                 NewCallback(reinterpret_cast<CallbackHelper*>(&callbacks_),
+                             &CallbackHelper::OnSeek));
+
+  EXPECT_FALSE(pipeline_.IsRunning());
+  EXPECT_FALSE(pipeline_.IsInitialized());
+  EXPECT_FALSE(pipeline_.IsRendered(""));
+  EXPECT_FALSE(pipeline_.IsRendered(AudioDecoder::major_mime_type()));
+  EXPECT_FALSE(pipeline_.IsRendered(VideoDecoder::major_mime_type()));
+
+  // Setting should still work.
+  EXPECT_EQ(0.0f, pipeline_.GetPlaybackRate());
+  pipeline_.SetPlaybackRate(-1.0f);
+  EXPECT_EQ(0.0f, pipeline_.GetPlaybackRate());
+  pipeline_.SetPlaybackRate(1.0f);
+  EXPECT_EQ(1.0f, pipeline_.GetPlaybackRate());
+
+  // Setting should still work.
+  EXPECT_EQ(0.0f, pipeline_.GetVolume());
+  pipeline_.SetVolume(-1.0f);
+  EXPECT_EQ(0.0f, pipeline_.GetVolume());
+  pipeline_.SetVolume(1.0f);
+  EXPECT_EQ(1.0f, pipeline_.GetVolume());
+
+  EXPECT_TRUE(kZero == pipeline_.GetTime());
+  EXPECT_TRUE(kZero == pipeline_.GetBufferedTime());
+  EXPECT_TRUE(kZero == pipeline_.GetDuration());
+
+  EXPECT_EQ(0, pipeline_.GetBufferedBytes());
+  EXPECT_EQ(0, pipeline_.GetTotalBytes());
+
+  // Should always get set to zero.
+  size_t width = 1u;
+  size_t height = 1u;
+  pipeline_.GetVideoSize(&width, &height);
+  EXPECT_EQ(0u, width);
+  EXPECT_EQ(0u, height);
+
+  EXPECT_EQ(PIPELINE_OK, pipeline_.GetError());
+}
+
 TEST_F(PipelineImplTest, NeverInitializes) {
   EXPECT_CALL(*mocks_->data_source(), Initialize(""))
       .WillOnce(Return(true));
   EXPECT_CALL(*mocks_->data_source(), Stop());
 
   // This test hangs during initialization by never calling
   // InitializationComplete().  StrictMock<> will ensure that the callback is
   // never executed.
   pipeline_.Start(mocks_, "",
                   NewCallback(reinterpret_cast<CallbackHelper*>(&callbacks_),
-                              &CallbackHelper::OnInitialize));
+                              &CallbackHelper::OnStart));
   message_loop_.RunAllPending();
 
   EXPECT_FALSE(pipeline_.IsInitialized());
   EXPECT_EQ(PIPELINE_OK, pipeline_.GetError());
 
   // Because our callback will get executed when the test tears down, we'll
   // verify that nothing has been called, then set our expectation for the call
   // made during tear down.
   Mock::VerifyAndClear(&callbacks_);
-  EXPECT_CALL(callbacks_, OnInitialize(false));
+  EXPECT_CALL(callbacks_, OnStart(false));
 }
 
 TEST_F(PipelineImplTest, RequiredFilterMissing) {
   mocks_->set_creation_successful(false);
 
   InitializePipeline(false);
   EXPECT_FALSE(pipeline_.IsInitialized());
   EXPECT_EQ(PIPELINE_ERROR_REQUIRED_FILTER_MISSING,
             pipeline_.GetError());
 }
 
 TEST_F(PipelineImplTest, URLNotFound) {
   EXPECT_CALL(*mocks_->data_source(), Initialize(""))
       .WillOnce(DoAll(Error(mocks_->data_source(),
                             PIPELINE_ERROR_URL_NOT_FOUND),
                       Return(false)));
   EXPECT_CALL(*mocks_->data_source(), Stop());
 
   InitializePipeline(false);
   EXPECT_FALSE(pipeline_.IsInitialized());
   EXPECT_EQ(PIPELINE_ERROR_URL_NOT_FOUND, pipeline_.GetError());
 }
 
 TEST_F(PipelineImplTest, NoStreams) {
-  MockDemuxerStreamVector streams;
-  InitializeDataSource();
-  InitializeDemuxer(&streams);
+  // Manually set these expecations because SetPlaybackRate() is not called if
+  // we cannot fully initialize the pipeline.
+  EXPECT_CALL(*mocks_->data_source(), Initialize(""))
+      .WillOnce(DoAll(InitializationComplete(mocks_->data_source()),
+                      Return(true)));
+  EXPECT_CALL(*mocks_->data_source(), Stop());
+
+  EXPECT_CALL(*mocks_->demuxer(), Initialize(mocks_->data_source()))
+      .WillOnce(DoAll(InitializationComplete(mocks_->demuxer()),
+                      Return(true)));
+  EXPECT_CALL(*mocks_->demuxer(), GetNumberOfStreams())
+      .WillRepeatedly(Return(0));
+  EXPECT_CALL(*mocks_->demuxer(), Stop());
 
   InitializePipeline(false);
   EXPECT_FALSE(pipeline_.IsInitialized());
   EXPECT_EQ(PIPELINE_ERROR_COULD_NOT_RENDER, pipeline_.GetError());
 }
 
 TEST_F(PipelineImplTest, AudioStream) {
   scoped_refptr<StrictMock<MockDemuxerStream> > stream =
       new StrictMock<MockDemuxerStream>("audio/x-foo");
   MockDemuxerStreamVector streams;
@@ skipping 102 matching lines @@
   // The audio renderer should receive a call to SetVolume().
   float expected = 0.5f;
   EXPECT_CALL(*mocks_->audio_renderer(), SetVolume(expected));
 
   // Initialize then set volume!
   InitializePipeline(true);
   pipeline_.SetVolume(expected);
 }
 
 }  // namespace media