Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1494973002: [turbofan] Introduce ToBooleanHints on ToBoolean operators. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce ToBooleanHints on ToBoolean operators. Extract ToBoolean hints from the fullcodegen code object and put them into the ToBoolean nodes created by the AstGraphBuilder. We currently do not yet consume this feedback, that will be done in a followup CL. R=mstarzinger@chromium.org BUG=v8:4583 LOG=n Committed: https://crrev.com/9298b43029a963c88cfc478d925edd49cd2c449c Cr-Commit-Position: refs/heads/master@{#32576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -37 lines) Patch
M src/base/flags.h View 3 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 6 chunks +16 lines, -8 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/js-operator.cc View 3 chunks +16 lines, -1 line 0 comments Download
M src/compiler/type-hint-analyzer.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/type-hint-analyzer.cc View 3 chunks +29 lines, -2 lines 0 comments Download
M src/compiler/type-hints.h View 2 chunks +26 lines, -0 lines 0 comments Download
M src/compiler/type-hints.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 7 chunks +21 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-03 13:19:27 UTC) #1
Benedikt Meurer
Hey Michi, Here's the CL to introduce ToBoolean operator hints. Manually verified that we take ...
5 years ago (2015-12-03 13:20:42 UTC) #2
Michael Starzinger
LGTM.
5 years ago (2015-12-03 15:12:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494973002/1
5 years ago (2015-12-03 15:22:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 16:48:11 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 16:48:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9298b43029a963c88cfc478d925edd49cd2c449c
Cr-Commit-Position: refs/heads/master@{#32576}

Powered by Google App Engine
This is Rietveld 408576698