Add ...:version_header dependency to setup_lib

Add ...:version_header dependency to setup_lib

Adding common_constants.gyp:version_header dependency to setup_lib because
installer_crash_reporter_client.cc includes chrome/common/chrome_version.h.
This fails to compile flakily on Windows.

BUG=558552
TBR=joenotcharles@chromium.org,grt@chromium.org

Committed: https://crrev.com/163a76cb24777c945ab54b7bfbe899fb194b819d
Cr-Commit-Position: refs/heads/master@{#362952}

[battre, 2015-12-03 10:23:37]

battre@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[battre, 2015-12-03 10:23:37]

Pawel, could you please review this? Thanks.

[Paweł Hajdan Jr., 2015-12-03 10:25:29]

LGTM

Do you also need similar change for GN?

[battre, 2015-12-03 10:26:39]

On 2015/12/03 10:25:29, Paweł Hajdan Jr. wrote:
> LGTM
> 
> Do you also need similar change for GN?

The .gn file is good:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/installer/s...

[battre, 2015-12-03 10:26:42]

The CQ bit was checked by battre@chromium.org

[commit-bot: I haz the power, 2015-12-03 10:27:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1494933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1494933002/1

[commit-bot: I haz the power, 2015-12-03 11:05:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-03 11:06:53]

Description was changed from

==========
Add ...:version_header dependency to setup_lib

Adding common_constants.gyp:version_header dependency to setup_lib because
installer_crash_reporter_client.cc includes chrome/common/chrome_version.h.
This fails to compile flakily on Windows.

BUG=558552
TBR=joenotcharles@chromium.org,grt@chromium.org
==========

to

==========
Add ...:version_header dependency to setup_lib

Adding common_constants.gyp:version_header dependency to setup_lib because
installer_crash_reporter_client.cc includes chrome/common/chrome_version.h.
This fails to compile flakily on Windows.

BUG=558552
TBR=joenotcharles@chromium.org,grt@chromium.org

Committed: https://crrev.com/163a76cb24777c945ab54b7bfbe899fb194b819d
Cr-Commit-Position: refs/heads/master@{#362952}
==========

[commit-bot: I haz the power, 2015-12-03 11:06:53]

Patchset 1 (id:??) landed as
https://crrev.com/163a76cb24777c945ab54b7bfbe899fb194b819d
Cr-Commit-Position: refs/heads/master@{#362952}