Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2155)

Unified Diff: ash/wm/overview/window_selector_unittest.cc

Issue 149493008: Use active window if on current workspace for fullscreen mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only consider the currently active window on current root. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_selector_unittest.cc
diff --git a/ash/wm/overview/window_selector_unittest.cc b/ash/wm/overview/window_selector_unittest.cc
index c23fedc189d4d293b3ed92475c59743b5e19f62a..5bdcc67e631ebefaf31beda4af9c98801a10a275 100644
--- a/ash/wm/overview/window_selector_unittest.cc
+++ b/ash/wm/overview/window_selector_unittest.cc
@@ -315,6 +315,16 @@ TEST_F(WindowSelectorTest, FullscreenWindow) {
ToggleOverview();
ClickWindow(window2.get());
EXPECT_TRUE(wm::GetWindowState(window1.get())->IsFullscreen());
+
+ // Verify that selecting the panel will make it visible.
+ // TODO(flackr): Click on panel rather than cycle to it when
+ // clicking on panels is fixed, see http://crbug.com/339834.
+ Cycle(WindowSelector::FORWARD);
+ Cycle(WindowSelector::FORWARD);
+ StopCycling();
+ EXPECT_TRUE(wm::GetWindowState(panel1.get())->IsActive());
+ EXPECT_TRUE(wm::GetWindowState(window1.get())->IsFullscreen());
+ EXPECT_TRUE(panel1->IsVisible());
}
// Tests that the shelf dimming state is removed while in overview and restored

Powered by Google App Engine
This is Rietveld 408576698