Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2870)

Unified Diff: ash/wm/overview/window_selector.cc

Issue 149493008: Use active window if on current workspace for fullscreen mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_selector.cc
diff --git a/ash/wm/overview/window_selector.cc b/ash/wm/overview/window_selector.cc
index aa351856a5a66dd93da76fcd433df29a40709768..e3828fdc73e24ac50b6a151ec56bde8fcb7b8633 100644
--- a/ash/wm/overview/window_selector.cc
+++ b/ash/wm/overview/window_selector.cc
@@ -386,6 +386,11 @@ void WindowSelector::SelectWindow(aura::Window* window) {
// The selected window should not be minimized when window selection is
// ended.
(*iter)->RestoreWindowOnExit(window);
+ // The selected window will be activated, this activation should be ignored.
+ // After selecting the window, this object will be deleted so we just set
+ // ignore_activations_ rather than using AutoReset which would attempt to
+ // change the value back after deleting this WindowSelector.
+ ignore_activations_ = true;
delegate_->OnWindowSelected(window);
}

Powered by Google App Engine
This is Rietveld 408576698