Source/core/loader/cache/CachedResourceLoader.h - Issue 14949017: Implementation of W3C compliant CSP script-src nonce.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/cache/CachedResourceLoader.h

Issue 14949017: Implementation of W3C compliant CSP script-src nonce. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed broken nonce behavior on script redirects. Added test for redirects as well. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/loader/ResourceLoaderOptions.h ('K') | « Source/core/loader/ResourceLoaderOptions.h ('k') | Source/core/loader/cache/CachedResourceLoader.cpp » ('j') | Source/core/loader/cache/CachedResourceLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/cache/CachedResourceLoader.h

diff --git a/Source/core/loader/cache/CachedResourceLoader.h b/Source/core/loader/cache/CachedResourceLoader.h

index ac184bd7a3ee2b6dbf525e99097401f3d5e4cee4..b80d18fd3719ea604eb04b349d2c7b0541f8eca6 100644

--- a/Source/core/loader/cache/CachedResourceLoader.h

+++ b/Source/core/loader/cache/CachedResourceLoader.h

@@ -125,7 +125,7 @@ public:

void preload(CachedResource::Type, CachedResourceRequest&, const String& charset);

void checkForPendingPreloads();

void printPreloadStats();

- bool canRequest(CachedResource::Type, const KURL&, bool forPreload = false);

+ bool canRequest(CachedResource::Type, const KURL&, bool validNonce, bool forPreload = false);

abarth-chromium 2013/05/16 00:59:27 Why not pass the enum here instead of the bool?

jww 2013/05/16 20:59:00 Done.

void reportMemoryUsage(MemoryObjectInfo*) const;

@@ -146,6 +146,8 @@ private:

void notifyLoadedFromMemoryCache(CachedResource*);

bool checkInsecureContent(CachedResource::Type, const KURL&) const;

+ bool checkNonceFromInitiatorElement(const Element* initiatorElement);

void garbageCollectDocumentResourcesTimerFired(Timer<CachedResourceLoader>*);

void performPostLoadActions();