Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: chrome/browser/prerender/prerender_tab_helper.cc

Issue 14949012: Add instrumentation to see how often a local predictor prerender could be (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_tab_helper.cc
===================================================================
--- chrome/browser/prerender/prerender_tab_helper.cc (revision 199567)
+++ chrome/browser/prerender/prerender_tab_helper.cc (working copy)
@@ -9,6 +9,7 @@
#include "base/time.h"
#include "chrome/browser/predictors/logged_in_predictor_table.h"
#include "chrome/browser/prerender/prerender_histograms.h"
+#include "chrome/browser/prerender/prerender_local_predictor.h"
#include "chrome/browser/prerender/prerender_manager.h"
#include "chrome/browser/prerender/prerender_manager_factory.h"
#include "chrome/browser/profiles/profile.h"
@@ -29,6 +30,23 @@
namespace prerender {
+namespace {
+
+void ReportTabHelperURLSeenToLocalPredictor(
+ PrerenderManager* prerender_manager,
+ const GURL& url,
+ WebContents* web_contents) {
+ if (!prerender_manager)
+ return;
+ PrerenderLocalPredictor* local_predictor =
+ prerender_manager->local_predictor();
+ if (!local_predictor)
+ return;
+ local_predictor->OnTabHelperURLSeen(url, web_contents);
+}
+
+} // namespace
+
// Helper class to compute pixel-based stats on the paint progress
// between when a prerendered page is swapped in and when the onload event
// fires.
@@ -152,6 +170,8 @@
if (prerender_manager->IsWebContentsPrerendering(web_contents(), NULL))
return;
prerender_manager->MarkWebContentsAsNotPrerendered(web_contents());
+ ReportTabHelperURLSeenToLocalPredictor(prerender_manager, url,
+ web_contents());
}
void PrerenderTabHelper::DidCommitProvisionalLoadForFrame(
@@ -172,6 +192,8 @@
if (prerender_manager->IsWebContentsPrerendering(web_contents(), NULL))
return;
prerender_manager->RecordNavigation(validated_url);
+ ReportTabHelperURLSeenToLocalPredictor(prerender_manager, validated_url,
+ web_contents());
}
void PrerenderTabHelper::DidStopLoading(
« no previous file with comments | « chrome/browser/prerender/prerender_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698