Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/browser/prerender/prerender_local_predictor.cc

Issue 14949012: Add instrumentation to see how often a local predictor prerender could be (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_local_predictor.cc
===================================================================
--- chrome/browser/prerender/prerender_local_predictor.cc (revision 199567)
+++ chrome/browser/prerender/prerender_local_predictor.cc (working copy)
@@ -306,7 +306,8 @@
PrerenderManager* prerender_manager)
: prerender_manager_(prerender_manager),
is_visit_database_observer_(false),
- weak_factory_(this) {
+ weak_factory_(this),
+ current_prerender_would_have_matched_(false) {
RecordEvent(EVENT_CONSTRUCTED);
if (MessageLoop::current()) {
timer_.Start(FROM_HERE,
@@ -473,6 +474,7 @@
LogCandidateURLStats(info->candidate_urls_[0].url);
WebContents* source_web_contents = NULL;
+ bool multiple_source_web_contents_candidates = false;
#if !defined(OS_ANDROID)
// We need to figure out what tab launched the prerender. We do this by
@@ -484,8 +486,10 @@
// in the future.
for (TabContentsIterator it; !it.done(); it.Next()) {
if (it->GetURL() == info->source_url_.url) {
- source_web_contents = *it;
- break;
+ if (!source_web_contents)
+ source_web_contents = *it;
+ else
+ multiple_source_web_contents_candidates = true;
}
}
#endif
@@ -495,6 +499,10 @@
return;
}
+ if (multiple_source_web_contents_candidates)
+ RecordEvent(EVENT_PRERENDER_URL_LOOKUP_MULTIPLE_SOURCE_WEBCONTENTS_FOUND);
+
+
scoped_refptr<SessionStorageNamespace> session_storage_namespace =
source_web_contents->GetController().GetDefaultSessionStorageNamespace();
@@ -731,6 +739,7 @@
prerender_handle_.release());
prerender_handle_.reset(prerender_manager_->AddPrerenderFromLocalPredictor(
url, session_storage_namespace.get(), *size));
+ current_prerender_would_have_matched_ = false;
if (old_prerender_handle)
old_prerender_handle->OnCancel();
@@ -757,4 +766,27 @@
current_prerender_->actual_start_time = current_time;
}
+void PrerenderLocalPredictor::OnTabHelperURLSeen(
+ const GURL& url, WebContents* web_contents) {
+ RecordEvent(EVENT_TAB_HELPER_URL_SEEN);
+ if (current_prerender_would_have_matched_ ||
+ !prerender_handle_.get() ||
+ !prerender_handle_->Matches(url, NULL)) {
+ return;
+ }
+ RecordEvent(EVENT_TAB_HELPER_URL_SEEN_MATCH);
+ if (prerender_handle_->Matches(
+ url,
+ web_contents->GetController().GetDefaultSessionStorageNamespace())) {
+ RecordEvent(EVENT_TAB_HELPER_URL_SEEN_NAMESPACE_MATCH);
+ }
+ // If the namespace matches and the URL matches, we might be able to swap
+ // in. However, the actual code initating the swapin is in the renderer
+ // and is checking for other criteria (such as POSTs). However, there may
Shishir 2013/05/14 20:01:43 nit: Remove this however. The previous statment ha
tburkard 2013/05/14 20:04:40 Done.
+ // also be conditions when a swapin shoudl happen but does not. By recording
Shishir 2013/05/14 20:01:43 nit: should
tburkard 2013/05/14 20:04:40 Done.
+ // the two previous events, we can keep an eye on the magnitude of the
+ // discrepancy.
+ current_prerender_would_have_matched_ = true;
+}
+
} // namespace prerender

Powered by Google App Engine
This is Rietveld 408576698